Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8316304 in JDK 21 introduced a new field accessed through JNI #37813

Merged

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Dec 18, 2023

A new field sun.nio.fs.UnixFileAttributes.st_birthtime_sec is
introduced with https://bugs.openjdk.org/browse/JDK-8316304 and GraalVM
registers it for JNI access in 23.1

See
oracle/graal@6b9b813

This PR increases the expected number of JNI fields to avoid test
failures with the anticipated 23.1 CPU release in January. It also
increases the threshold to ensure backwards compatibility.

cc @jerboaa

A new field `sun.nio.fs.UnixFileAttributes.st_birthtime_sec` is
introduced with https://bugs.openjdk.org/browse/JDK-8316304 and GraalVM
registers it for JNI access in 23.1

See
oracle/graal@6b9b813

This PR increases the expected number of JNI fields to avoid test
failures with the anticipated 23.1 CPU release in January. It also
increases the threshold to ensure backwards compatibility.
@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Dec 18, 2023
Copy link

quarkus-bot bot commented Dec 18, 2023

/cc @Sanne (hibernate-orm), @gsmet (hibernate-orm), @yrodiere (hibernate-orm)

@zakkak zakkak requested a review from geoand December 18, 2023 15:28
@zakkak zakkak added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 18, 2023
Copy link

quarkus-bot bot commented Dec 18, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@zakkak zakkak merged commit 52e0884 into quarkusio:main Dec 18, 2023
19 checks passed
@zakkak zakkak deleted the 2023-12-18-update-jpa-postgresql-metrics branch December 18, 2023 16:11
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 18, 2023
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Dec 18, 2023
@jerboaa
Copy link
Contributor

jerboaa commented Dec 18, 2023

Thanks!

zakkak pushed a commit that referenced this pull request Dec 21, 2023
Similar fix to jpa-postgresql-withxml which was done in #37813 for
jpa-postgresql
zakkak added a commit to zakkak/quarkus that referenced this pull request Jan 9, 2024
Similar fix to main which was done in
quarkusio#37813 for jpa-postgresql and
in quarkusio#37879 for
jpa-postgresql-withxml.

Closes quarkusio#37809
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants