Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'day' support for scheduler every and delayed #38822

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Add 'day' support for scheduler every and delayed #38822

merged 1 commit into from
Feb 20, 2024

Conversation

manofthepeace
Copy link
Contributor

@manofthepeace manofthepeace commented Feb 16, 2024 •
edited
Loading

Fixes #38766

note: Documentation + javadoc not updated.

cc @mkouba

@gsmet gsmet requested a review from mkouba February 18, 2024 09:57
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
mkouba
mkouba reviewed Feb 19, 2024
View reviewed changes
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manofthepeace!

note: Documentation + javadoc not updated.

We'll need these updates as well ;-)

.../scheduler/common/src/main/java/io/quarkus/scheduler/common/runtime/util/SchedulerUtils.java Outdated Show resolved Hide resolved
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 20, 2024
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Feb 20, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 5be46ca.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2024 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Feb 20, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 5be46ca.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gastaldi gastaldi merged commit 883ece9 into quarkusio:main Feb 20, 2024
33 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Feb 20, 2024
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Feb 20, 2024
@manofthepeace manofthepeace deleted the schedulerDaysSupport branch February 20, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba approved these changes

Assignees
No one assigned
Labels
area/documentation area/scheduler kind/enhancement New feature or request
Projects
Quarkus Documentation
Status: Done
Milestone
3.9.0.CR1
Development

Successfully merging this pull request may close these issues.

SchedulerUtils Duration parsing breaks when using duration in days without explicit prefix
3 participants
@manofthepeace @mkouba @gastaldi