Detect .truststore and .keystore files as JKS #39243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite the declining usage of JKS (Java KeyStore) format, many Java guides and articles, such as https://tomcat.apache.org/tomcat-9.0-doc/ssl-howto.html (updated in 2024), still reference it extensively. Traditionally, JKS files are identified by three common extensions: .jks, .keystore, and .truststore. This commit addresses the recent breaking change where JKS is no longer the default keystore/truststore format. It introduces automatic association of files with extensions .keystore and .truststore to JKS format (in addition to .jks). This approach mitigates potential disruptions for users using these conventions.
michalvavrik
approved these changes
Mar 7, 2024
Status for workflow
|
|
Yeah, even though it is a legacy format, thanks @cescoffier |
sberyozkin
approved these changes
Mar 7, 2024
|
https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.9#keystore-and-trust-store-default-format-change probably needs to be updated with this change |
|
Yes! I will update it tomorrow. |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite the declining usage of JKS (Java KeyStore) format, many Java guides and articles, such as https://tomcat.apache.org/tomcat-9.0-doc/ssl-howto.html (updated in 2024), still reference it extensively. Traditionally, JKS files are identified by three common extensions: .jks, .keystore, and .truststore.
This commit addresses (reduces) the recent breaking change: JKS is no longer the default keystore/truststore format. It introduces the automatic association of files with extensions .keystore and .truststore to JKS format (in addition to .jks), which mitigates potential disruptions for users using these conventions.
@michalvavrik You recently reported this change. I decided to re-add the association of .keystore and .truststore as JKS. The reason is the abundance of resources using these conventions.