Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport hide EndUserSpanProcessor integration #39707

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

brunobat
Copy link
Contributor

@brunobat brunobat commented Mar 26, 2024

Backport implementation mitigating: #39667

Copy link

quarkus-bot bot commented Mar 26, 2024

/cc @radcortez (opentelemetry)

@brunobat
Copy link
Contributor Author

This should be also ported to 3.8.x if possible.

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are alright. I understand why it is desirable to keep the feature, just wanna note that this feature became even less reliable in recent release due to CDI request scope activation changes, so users might be double surprised it works worse than before. Thanks for changes.

Copy link

quarkus-bot bot commented Mar 26, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit a1f4fab.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

This comment has been minimized.

Copy link

quarkus-bot bot commented Mar 27, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit a1f4fab.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/websockets-next/server/deployment

io.quarkus.websockets.next.test.broadcast.BroadcastOnOpenTest.testLoMultiBidi - History

  • Messages: [c2] ==> expected: <true> but was: <false> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: Messages: [c2] ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214)
	at io.quarkus.websockets.next.test.broadcast.BroadcastOnOpenTest.assertBroadcast(BroadcastOnOpenTest.java:98)
	at io.quarkus.websockets.next.test.broadcast.BroadcastOnOpenTest.testLoMultiBidi(BroadcastOnOpenTest.java:50)

@geoand geoand merged commit 9002ec7 into quarkusio:3.9 Mar 27, 2024
52 checks passed
Copy link

🙈 The PR is closed and the preview is expired.

@gsmet gsmet added this to the 3.8.5 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants