Add mongo commands to otel span attributes

[vkn]

Solving #28473

A simple approach to add mongo commands to traces using CommandListener. Similar approach as it was in quarkus-opentracing but without relying on https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/mongo/mongo-3.1/library, but using the similiar though simpler code.

[quarkus-bot]

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

• title should preferably start with an uppercase character (if it makes sense!)

_{This message is automatically generated by a bot.}

[gsmet]

This looks like a very good contribution. I took the liberty to squash the commits and rebase.

@brunobat @loicmathieu could you have a look? It looks like a very nice addition.

[loicmathieu]

Overall it's good to me, very small integration so it's better not to rely on an external lib for that.

I add one suggestion but we can merge as is.

I'm also concern about the cost of adding one integration test for that, it's a lot for such small integration, I wonder if it's really needed WDYT @gsmet ? We can either add that in the existing MongoDB test or only rely on the unit test.

[loicmathieu]

Will also fix #40191

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 6d35887.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

[FroMage]

This is interesting. I wonder if we can add the same telemetry support to ORM and HR/Panache static methods.

[brunobat]

Was on PTO and only now I saw this...
The implementation should have been made in the OTel extension and not in the Mongo db one... MongoDB should not depend on OTel.
All other instrumentations work like that.

@vkn are you available to refactor the code in that way?

Also we lack documentation entries and additional IT tests for Uni, Multi, parent-child relationships and failure cases.

Also, the assertions need to verify the attributes of the spans.

[vkn]

@vkn are you available to refactor the code in that way?

@brunobat yes

[brunobat]

I'm concerned with the amount of data you are storing here... can you give an example of one of this events?
Can you just store what you need later?

[vkn]

@brunobat it is not big, just description of mongo connection, db name and command. You can inspect it by using BookResourceTest. But I could create another record to just save command name and the command itself, if you prefer

[vkn]

@brunobat I've moved the implementation to opentelemetry extension. Is this enough for a new PR?

[brunobat]

It is but there are also other improvements needed:

Also we lack documentation entries and additional IT tests for Uni, Multi, parent-child relationships and failure cases.

Also, the assertions need to verify the attributes of the spans.

[vkn]

@brunobat Opened #40472

I'm not sure about additional IT tests. There is already a test for for reactive endpoint with assertion for attributes:

    @Test
    void reactiveClient() {
        testInsertBooks("/reactive-books");
        assertTraceAvailable("my-reactive-collection");
    }