Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a method to walk a subtree of a given PathTree #40415

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

aloubyansky
Copy link
Member

This PR also adds a convenient method PathTree.walkIfContains(relativePath, visitor) for walking over a subtree of a given PathTree. It's also a more efficient alternative to the current approach of using FilteredPathTree.

This PR also removes never used CachedPathTree which wasn't a complete implementation.

@aloubyansky aloubyansky requested a review from mkouba May 2, 2024 14:51
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/qute The template engine area/vertx labels May 2, 2024

This comment has been minimized.

This comment has been minimized.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aloubyansky I wonder if the failure is related given I think Qute is now using this infra?

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Jun 6, 2024

@aloubyansky I think we still have a problem on Windows here.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a log file in the PR: [extensions/qute/deployment/log](https://github.com/quarkusio/quarkus/pull/40415/files#diff-40a826f6c73b87b94607d079015516f18ae0028a85b93068ff025c1125bea062). It needs to removed.

@aloubyansky
Copy link
Member Author

Yeah, I still need to debug it

This comment has been minimized.

@aloubyansky aloubyansky force-pushed the pathtree-walk-subtree branch 3 times, most recently from 67ca83d to 8ebd37b Compare June 9, 2024 06:04
Copy link

quarkus-bot bot commented Jun 9, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit f53be2f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

  • Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

  • Expecting actual: ["-6","-7","-9","-10","-11","-12","-13","-14"] to start with: ["-6", "-7", "-8", "-9"] - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual:
  ["-6","-7","-9","-10","-11","-12","-13","-14"]
to start with:
  ["-6", "-7", "-8", "-9"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:41)

@aloubyansky
Copy link
Member Author

@gsmet @mkouba this one's ready for review.

This may raise a question why not always perform case-sensitive path checks. We rely on pretty much Files.exists(Path.resolve(path)) everywhere else.
What we do in case of Windows here has a certain cost, since we haven't had an issue everywhere else I thought of keeping it the way it is for now but added a method to PathTreeUtils to perform this kind of check where necessary.
If run into these issues in the future in other areas, we could reconsider the default check.

@mkouba mkouba requested a review from gsmet July 3, 2024 14:55
@aloubyansky
Copy link
Member Author

@mkouba does it look ok to you?

Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aloubyansky aloubyansky merged commit 346a834 into quarkusio:main Aug 1, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/qute The template engine area/vertx triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants