-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a method to walk a subtree of a given PathTree #40415
Conversation
This comment has been minimized.
This comment has been minimized.
8d46d66
to
7d7d0c2
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aloubyansky I wonder if the failure is related given I think Qute is now using this infra?
7d7d0c2
to
429fe0d
Compare
This comment has been minimized.
This comment has been minimized.
429fe0d
to
06d53c9
Compare
This comment has been minimized.
This comment has been minimized.
06d53c9
to
e8567b9
Compare
This comment has been minimized.
This comment has been minimized.
e8567b9
to
7a543f3
Compare
This comment has been minimized.
This comment has been minimized.
7a543f3
to
ad4d26f
Compare
This comment has been minimized.
This comment has been minimized.
ad4d26f
to
08eca8b
Compare
This comment has been minimized.
This comment has been minimized.
@aloubyansky I think we still have a problem on Windows here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a log file in the PR: [extensions/qute/deployment/log](https://github.com/quarkusio/quarkus/pull/40415/files#diff-40a826f6c73b87b94607d079015516f18ae0028a85b93068ff025c1125bea062)
. It needs to removed.
Yeah, I still need to debug it |
08eca8b
to
8caea92
Compare
This comment has been minimized.
This comment has been minimized.
67ca83d
to
8ebd37b
Compare
8ebd37b
to
f53be2f
Compare
Status for workflow
|
@gsmet @mkouba this one's ready for review. This may raise a question why not always perform case-sensitive path checks. We rely on pretty much |
@mkouba does it look ok to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This PR also adds a convenient method
PathTree.walkIfContains(relativePath, visitor)
for walking over a subtree of a givenPathTree
. It's also a more efficient alternative to the current approach of usingFilteredPathTree
.This PR also removes never used
CachedPathTree
which wasn't a complete implementation.