Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump OpenJDK images to 1.19 #40537

Merged
merged 1 commit into from
May 10, 2024
Merged

Bump OpenJDK images to 1.19 #40537

merged 1 commit into from
May 10, 2024

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented May 9, 2024

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/kubernetes area/maven area/platform Issues related to definition and interaction with Quarkus Platform labels May 9, 2024
@gastaldi gastaldi requested review from iocanel, cescoffier and gsmet May 9, 2024 13:10
@gastaldi gastaldi requested a review from geoand May 9, 2024 15:25
@geoand
Copy link
Contributor

geoand commented May 9, 2024

Any idea what the changes are for the new version?

@gastaldi
Copy link
Contributor Author

gastaldi commented May 9, 2024 •
edited
Loading

AFAIK it fixes some CVE issues and bumps some components. Shouldn't affect the current Quarkus usage IMHO. Let me see if I can find the release notes

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented May 9, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 0081d9f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ Maven Tests - JDK 17 Windows

📦 integration-tests/maven

✖ io.quarkus.maven.it.CreateProjectMojoIT.testProjectGenerationFromScratch - History

  • Cannot delete directory: target\test-classes\projects\project-generation - java.lang.RuntimeException
java.lang.RuntimeException: Cannot delete directory: target\test-classes\projects\project-generation
	at io.quarkus.maven.it.MojoTestBase.initEmptyProject(MojoTestBase.java:72)
	at io.quarkus.maven.it.CreateProjectMojoIT.testProjectGenerationFromScratch(CreateProjectMojoIT.java:60)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: org.apache.commons.io.IOExceptionList: 1 exception(s): [org.apache.commons.io.IOIndexedException: IOException #0: Cannot delete file: target\test-classes\projects\project-generation\build-create-project-generation.log]
	at org.apache.commons.io.IOExceptionList.checkEmpty(IOExceptionList.java:50)

✖ io.quarkus.maven.it.CreateProjectMojoIT.testProjectGenerationFromScratch - History

  • Cannot delete directory: target\test-classes\projects\project-generation - java.lang.RuntimeException
java.lang.RuntimeException: Cannot delete directory: target\test-classes\projects\project-generation
	at io.quarkus.maven.it.MojoTestBase.initEmptyProject(MojoTestBase.java:72)
	at io.quarkus.maven.it.CreateProjectMojoIT.testProjectGenerationFromScratch(CreateProjectMojoIT.java:60)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: org.apache.commons.io.IOExceptionList: 1 exception(s): [org.apache.commons.io.IOIndexedException: IOException #0: Cannot delete file: target\test-classes\projects\project-generation\build-create-project-generation.log]
	at org.apache.commons.io.IOExceptionList.checkEmpty(IOExceptionList.java:50)

gsmet added a commit to gsmet/quarkus that referenced this pull request May 10, 2024
@gsmet
Avoid using the same directory twice in Maven ITs
0c7b77f 
Doesn't work very well on Windows CI as deleting files can be
problematic.
See:
quarkusio#40537 (comment)
@gastaldi
Copy link
Contributor Author

@geoand sorry for the late reply, here is why we need to upgrade: https://catalog.redhat.com/software/containers/ubi8/openjdk-17-runtime/618bdc5f843af1624c4e4ba8?q=ubi8&architecture=amd64&image=65a903108cea3515b72ad7a8

@gastaldi gastaldi merged commit 0a9998e into quarkusio:main May 10, 2024
51 checks passed
@gastaldi gastaldi deleted the bump_ubi branch May 10, 2024 12:07
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone May 10, 2024
@geoand
Copy link
Contributor

geoand commented May 10, 2024

Cool, thanks

@gsmet gsmet mentioned this pull request May 10, 2024
Merged
@gsmet gsmet modified the milestones: 3.11 - main, 3.10.1 May 10, 2024
gsmet added a commit to gsmet/quarkus that referenced this pull request May 10, 2024
@gsmet
Avoid using the same directory twice in Maven ITs
12a0330 
Doesn't work very well on Windows CI as deleting files can be
problematic.
See:
quarkusio#40537 (comment)

(cherry picked from commit 0c7b77f)
@gsmet gsmet removed this from the 3.10.1 milestone May 22, 2024
@gsmet gsmet added this to the 3.8.5 milestone May 22, 2024
@gsmet gsmet mentioned this pull request Jun 26, 2024
Closed
jedla97 added a commit to jedla97/quarkus that referenced this pull request Jun 30, 2024
@jedla97
Bump ubi image to 19 for jib
b9e6d5b 
Follow up of quarkusio#40537 as this was missed
jedla97 added a commit to jedla97/quarkus that referenced this pull request Jul 1, 2024
@jedla97
Bump ubi image to 1.19 for jib
b310b26 
Follow up of quarkusio#40537 as this was missed
@jedla97 jedla97 mentioned this pull request Jul 1, 2024
Merged
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Jul 1, 2024
@jedla97 @gsmet
Bump ubi image to 1.19 for jib
26ddce4 
Follow up of quarkusio#40537 as this was missed

(cherry picked from commit b310b26)
@Felk Felk mentioned this pull request Jul 24, 2024
Merged
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this pull request Jul 31, 2024
@gsmet @holly-cummins
Avoid using the same directory twice in Maven ITs
ff8cd1b 
Doesn't work very well on Windows CI as deleting files can be
problematic.
See:
quarkusio#40537 (comment)
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this pull request Jul 31, 2024
@jedla97 @holly-cummins
Bump ubi image to 1.19 for jib
7029e41 
Follow up of quarkusio#40537 as this was missed
gsmet added a commit to gsmet/quarkus that referenced this pull request Aug 8, 2024
@gsmet
Avoid using the same directory twice in Maven ITs
1f3b87d 
Doesn't work very well on Windows CI as deleting files can be
problematic.
See:
quarkusio#40537 (comment)

(cherry picked from commit 0c7b77f)
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Aug 14, 2024
@jedla97 @gsmet
Bump ubi image to 1.19 for jib
305911b 
Follow up of quarkusio#40537 as this was missed

(cherry picked from commit b310b26)
danielsoro pushed a commit to danielsoro/quarkus that referenced this pull request Sep 20, 2024
@jedla97 @danielsoro
Bump ubi image to 1.19 for jib
a68324b 
Follow up of quarkusio#40537 as this was missed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@cescoffier cescoffier cescoffier approved these changes

@iocanel iocanel Awaiting requested review from iocanel

@geoand geoand Awaiting requested review from geoand

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/kubernetes area/maven area/platform Issues related to definition and interaction with Quarkus Platform triage/flaky-test
Projects
None yet
Milestone
3.8.5
Development

Successfully merging this pull request may close these issues.

Update ubi8/openjdk-VERSION from 1.18 to 1.19
4 participants
@gastaldi @geoand @cescoffier @gsmet