-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce container-image-podman extension #40729
Conversation
5b61219
to
3c505d1
Compare
/cc @gsmet (elasticsearch), @loicmathieu (elasticsearch), @yrodiere (elasticsearch) |
This comment has been minimized.
This comment has been minimized.
ab0c151
to
11304e9
Compare
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
extensions/container-image/container-image-docker-common/pom.xml
Outdated
Show resolved
Hide resolved
...age/container-image-docker-common/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Show resolved
Hide resolved
core/deployment/src/main/java/io/quarkus/deployment/util/ContainerRuntimeUtil.java
Show resolved
Hide resolved
...va/io/quarkus/container/image/docker/common/deployment/RedHatOpenJDKRuntimeBaseProvider.java
Outdated
Show resolved
Hide resolved
5994156
to
c0a2aaa
Compare
...c/main/java/io/quarkus/datasource/deployment/devservices/DevServicesDatasourceProcessor.java
Outdated
Show resolved
Hide resolved
c0a2aaa
to
5a4d893
Compare
a047db3
to
b8438ce
Compare
This comment has been minimized.
This comment has been minimized.
1b3f17c
to
f7ea4d5
Compare
Not sure why the documentation CI is failing. I didn't change any of the docs since the last build which succeeded. I did rebase from main, so maybe something there broke it? |
This comment has been minimized.
This comment has been minimized.
cc @gsmet |
#40775 was merged which hopefully fixes the doc issue |
f7ea4d5
to
e39d84e
Compare
I just rebased from main again to pull this in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Status for workflow
|
Status for workflow
|
Introduce a new
container-image-podman
extension. See the conversation history on #40699 for the details that were discussed between myself and @geoand .Essentially this refactors the current
container-image-docker
extension and adds a common layer underneath and pulls lots of common functionality up to that new common layer. Then it adds a newcontainer-image-podman
extension on top of the common layer.