Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onError for Dev UI streaming #40898

Merged
merged 1 commit into from
May 30, 2024

Conversation

phillip-kruger
Copy link
Member

This PR adds support for errors in streaming methods in Dev UI. It also adds an config option to allow extension developers to switch on the Json RPC log. This is useful for non-core extension developers.

When using streaming in your extension, you can now get errors like this:

this._errorObserver = this.jsonRpc.errorStream().onNext(jsonRpcResponse => {
    console.log(jsonRpcResponse);
}).onError(error => {
    console.log(error);
});

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I verify it does solve the reported problem

@phillip-kruger phillip-kruger merged commit ba50144 into quarkusio:main May 30, 2024
49 of 51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone May 30, 2024
@gsmet gsmet modified the milestones: 3.12 - main, 3.11.1 Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants