-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update maven wrapper to 3.3.2 #40911
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I added a small comment.
As for the failing tests: one you're happy with the changes, you need to do a quick build to install the artifacts and then run mvn clean verify -Dsnap
in the modules with failing tests (and only them!).
1106014
to
7c0eb94
Compare
This comment has been minimized.
This comment has been minimized.
@gsmet looks like there was a OOM on windows;
looks ok on my fork; https://github.com/manofthepeace/quarkus/actions/runs/9565837706 |
This comment has been minimized.
This comment has been minimized.
7c0eb94
to
1c91616
Compare
@gsmet rebased this one, mind taking another look? This does not change the behaviour in how it used to work with the older wrapper; as noted in the comment here ; #40911 (comment) |
Ah yes, sorry I totally forgot about it but it's something that would be nice to have in 3.14. |
Status for workflow
|
Status for workflow
|
Thanks! |
This updates the maven wrapper from 3.2.0 to 3.3.2.
The new version uses, by default, a script-only variant that does not need the jar, nor the maven downloader java source file. Type can be changed if needed. More info here; https://maven.apache.org/wrapper/index.html#usage-with-or-without-binary-jar