Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump io.fabric8:maven-model-helper from 36 to 37 #41408

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 25, 2024

Bumps io.fabric8:maven-model-helper from 36 to 37.

Release notes

Sourced from io.fabric8:maven-model-helper's releases.

37

What's Changed

Full Changelog: fabric8io/maven-model-helper@v36...v37

Commits
  • 5ac1a01 [maven-release-plugin] prepare release v37
  • 1a0b134 Added parenthesis for readability
  • 5847331 feat: apply indentation from input format - if specified - on existing pom (#...
  • 3f71055 Bump org.apache.maven:maven-model from 3.9.7 to 3.9.8 (#150)
  • 434cca4 Bump org.jboss:jboss-parent from 45 to 46 (#149)
  • 28f51ab Update pom.xml
  • cbc2db8 Update Git URL
  • 781d999 Bump org.sonatype.plugins:nexus-staging-maven-plugin (#146)
  • 0999c32 Bump org.apache.maven:maven-model from 3.9.6 to 3.9.7 (#144)
  • e48eddf --- (#143)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [io.fabric8:maven-model-helper](https://github.com/fabric8io/maven-model-helper) from 36 to 37.
- [Release notes](https://github.com/fabric8io/maven-model-helper/releases)
- [Commits](fabric8io/maven-model-helper@v36...v37)

---
updated-dependencies:
- dependency-name: io.fabric8:maven-model-helper
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the area/dependencies Pull requests that update a dependency file label Jun 25, 2024
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/platform Issues related to definition and interaction with Quarkus Platform labels Jun 25, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 25, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 16cf3ef.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/reactive-messaging-kafka

io.quarkus.it.kafka.KafkaConnectorTest.testFruits - History

  • Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.it.kafka.KafkaConnectorTest.testFruits(KafkaConnectorTest.java:63)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)

⚙️ JVM Tests - JDK 21

📦 integration-tests/reactive-messaging-kafka

io.quarkus.it.kafka.KafkaConnectorTest.testFruits - History

  • Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.it.kafka.KafkaConnectorTest.testFruits(KafkaConnectorTest.java:63)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

@gsmet gsmet merged commit 7336897 into main Jun 26, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jun 26, 2024
@dependabot dependabot bot deleted the dependabot/maven/io.fabric8-maven-model-helper-37 branch June 26, 2024 07:21
@gsmet gsmet modified the milestones: 3.13 - main, 3.12.1 Jun 26, 2024
@rsvoboda
Copy link
Member

Hi @gastaldi. What's the motivation to backport this change into 3.8 stream?

@gastaldi
Copy link
Contributor

@rsvoboda basically the fix in fabric8io/maven-model-helper@5847331 which handles custom pom.xml indentation properly

@gsmet gsmet modified the milestones: 3.12.1, 3.8.6 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/platform Issues related to definition and interaction with Quarkus Platform kind/component-upgrade triage/flaky-test
Projects
Development

Successfully merging this pull request may close these issues.

3 participants