Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSockets Next: fix the default unhandled-failure-strategy #41413

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jun 25, 2024

  • do not attempt to close a closed connection and get rid of superfluous WARN message

- do not attempt to close a closed connection and get rid of superfluous
WARN message
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 25, 2024
Copy link

quarkus-bot bot commented Jun 25, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 0f64a36.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/websockets-next/deployment

io.quarkus.websockets.next.test.security.HttpUpgradeRedirectOnFailureTest.testRedirectOnFailure - History

  • Condition with Lambda expression in io.quarkus.websockets.next.test.utils.WSClient was not fulfilled within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.websockets.next.test.utils.WSClient was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.websockets.next.test.utils.WSClient.waitForMessages(WSClient.java:125)
	at io.quarkus.websockets.next.test.security.HttpUpgradeRedirectOnFailureTest.testRedirectOnFailure(HttpUpgradeRedirectOnFailureTest.java:80)

@mkouba mkouba merged commit a1b3a14 into quarkusio:main Jun 25, 2024
20 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 25, 2024
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jun 25, 2024
@gsmet gsmet modified the milestones: 3.13 - main, 3.12.1 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants