Make sure generated quarkus-artifact.properties is stable #41587
+58
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, it contains a timestamp, which is going to be in the way of the cache. Also make sure the properties are sorted.
quarkus-bot
bot
added
area/core
area/devtools
gsmet
added a commit
to gsmet/develocity-build-config-samples
that referenced
this pull request
Jul 1, 2024
When running ITs for native, we need quarkus-artifact.properties to be around so it needs to be part of the cache. Also make it an input of Failsafe. This file contains a relative path to the binary to run and a few additional metadata such as the full GraalVM version. Whenever this version has changed, we need to run the tests again so it makes sense to make it an input. Note that we will need quarkusio/quarkus#41587 to be in so that quarkus-artifact.properties doesn't contain a timestamp.
gsmet
added a commit
to gsmet/develocity-build-config-samples
that referenced
this pull request
Jul 1, 2024
When running ITs for native, we need quarkus-artifact.properties to be around so it needs to be part of the cache. Also make it an input of Failsafe. This file contains a relative path to the binary to run and a few additional metadata such as the full GraalVM version. Whenever this version has changed, we need to run the tests again so it makes sense to make it an input. Note that we will need quarkusio/quarkus#41587 to be in so that quarkus-artifact.properties doesn't contain a timestamp. Signed-off-by: Guillaume Smet <guillaume.smet@gmail.com>
|
The timestamp is actually not a problem as the file is not a direct input, its entries are parsed and used to create a list of inputs The sorting is important though as the order matters on compile classpath normalization. |
|
@jprinet I actually made it an input of the Failsafe goal in gradle/develocity-build-config-samples#1280. But I can drop it from the extension PR if you think it's better not to have it as an input. That being said, even if we don't make it an input, I would prefer this PR to go in. |
jprinet
pushed a commit
to gradle/develocity-build-config-samples
that referenced
this pull request
Jul 1, 2024
* Add quarkus-artifact.properties as an output of quarkus:build When running ITs for native, we need quarkus-artifact.properties to be around so it needs to be part of the cache. Also make it an input of Failsafe. This file contains a relative path to the binary to run and a few additional metadata such as the full GraalVM version. Whenever this version has changed, we need to run the tests again so it makes sense to make it an input. Note that we will need quarkusio/quarkus#41587 to be in so that quarkus-artifact.properties doesn't contain a timestamp. Signed-off-by: Guillaume Smet <guillaume.smet@gmail.com> * Do not register quarkus-artifact.properties as input of Failsafe Signed-off-by: Guillaume Smet <guillaume.smet@gmail.com> --------- Signed-off-by: Guillaume Smet <guillaume.smet@gmail.com>
aloubyansky
approved these changes
Jul 1, 2024
Status for workflow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, it contains a timestamp, which is going to be in the way of the cache.
Also make sure the properties are sorted.
/cc @jprinet