Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade .sdkmanrc to mvnd 1.0.0 #41628

Closed
wants to merge 1 commit into from
Closed

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jul 2, 2024

mvnd 1.0.1 is not compatible with our build due to: apache/maven-mvnd#1031

Error is that ${maven.multiModuleProjectDirectory} is not interpolated anymore:

/home/gsmet/git/quarkus/independent-projects/resteasy-reactive/common/processor/${maven.multiModuleProjectDirectory}/.forbiddenapis/banned-signatures-common.txt

mvnd 1.0.1 is not compatible with our build due to:
apache/maven-mvnd#1031
@gsmet gsmet marked this pull request as draft July 2, 2024 14:34
@gsmet
Copy link
Member Author

gsmet commented Jul 2, 2024

Actually, it's even an issue with 1.0.0. The last working version is 1.0-m8-m39.

@gsmet
Copy link
Member Author

gsmet commented Jul 2, 2024

@manofthepeace would you be willing to have a look at how we can adjust our build to be compatible with the recent versions?
I couldn't really extract something that would work in all cases (including when using -f) from what I quickly read from the links in the issue.

@manofthepeace
Copy link
Contributor

Looks like it relates to this issue; #41323 @ppalaga seems to have been looking a bit in to it. I can also look into it in my spare time for sure. Is reverting back to 1.0-m8-m39 and maven 3.9.5 an option worse case, or you prefer just fixing it whatever the time it takes? Because I wonder if we need apache/maven#1589 / maven 3.9.9

@gsmet
Copy link
Member Author

gsmet commented Jul 2, 2024

For now, I would say we should revert just in the .sdkmanrc, even if not ideal.

But we should make sure we will have a path forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants