Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exceptions when running checkMissingCommand #41633

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jul 2, 2024

We want to check for the missing commands only, any other error will have to be handled by Picocli later (and thus will properly handle the formatting of the feedback and avoid a stacktrace).

Fixes #41513

We want to check for the missing commands only, any other error will
have to be handled by Picocli later (and thus will properly handle the
formatting of the feedback and avoid a stacktrace).

Fixes quarkusio#41513
@gsmet gsmet requested a review from gastaldi July 2, 2024 14:46
@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Jul 2, 2024
@gsmet
Copy link
Member Author

gsmet commented Jul 2, 2024

@radcortez this is the fix for the issue I reported about getting stacktrace when calling quarkus config enc with no parameters.

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 2, 2024
@gsmet gsmet merged commit c85f008 into quarkusio:main Jul 2, 2024
19 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 2, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 2, 2024
@gsmet gsmet modified the milestones: 3.13 - main, 3.12.1 Jul 2, 2024
@gsmet gsmet modified the milestones: 3.12.1, 3.8.6 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarkus CLI - Some expected errors lead to a stacktrace and they shouldn't
3 participants