Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: removed collections, which are updated, but never queried #41735

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

dk2k
Copy link
Contributor

@dk2k dk2k commented Jul 6, 2024

No description provided.

Copy link

quarkus-bot bot commented Jul 6, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/qute The template engine labels Jul 6, 2024
@gsmet gsmet requested a review from mkouba August 8, 2024 13:36
@@ -486,7 +486,6 @@ && isNotLocatedByCustomTemplateLocator(locatorPatternsBuildItem.getLocationPatte

Map<String, String> bindings = new HashMap<>();
List<Type> parameters = canonicalConstructor.parameterTypes();
List<String> parameterNames = new ArrayList<>(parameters.size());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@gsmet gsmet force-pushed the dk2k_removed_unneeded_collections branch from 8a883ad to 6141cea Compare August 8, 2024 18:36
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 8, 2024
Copy link

quarkus-bot bot commented Aug 8, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 6141cea.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit 78cece4 into quarkusio:main Aug 12, 2024
25 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Aug 12, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 12, 2024
@gsmet
Copy link
Member

gsmet commented Aug 12, 2024

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/qute The template engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants