Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize internal packages in ClassLoaderHelper #41874

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jul 13, 2024

  • Rename ClassloadHelper to the more consistent ClassLoaderHelper
  • Add a few internal packages
  • Centralize the internal packages now that we have a common CL artifact

@quarkus-bot quarkus-bot bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE area/platform Issues related to definition and interaction with Quarkus Platform area/qute The template engine area/reactive-messaging area/rest area/security area/smallrye area/spring Issues relating to the Spring integration area/testing labels Jul 13, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 13, 2024

/cc @yrodiere (hibernate-orm)

@quarkus-bot

This comment has been minimized.

@gsmet gsmet requested a review from geoand July 16, 2024 16:04
- Rename ClassloadHelper to the more consistent ClassLoaderHelper
- Add a few internal packages
- Centralize the internal packages now that we have a common CL artifact
@gsmet gsmet force-pushed the centralize-internal-packages branch from 015e65e to 6e9c7af Compare July 22, 2024 13:00
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 22, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 6e9c7af.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.traces.OpenTelemetryReactiveRoutesTest.nonRoot - History

  • event executor terminated - java.util.concurrent.RejectedExecutionException
java.util.concurrent.RejectedExecutionException: event executor terminated
	at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:931)
	at io.netty.util.concurrent.SingleThreadEventExecutor.offerTask(SingleThreadEventExecutor.java:350)
	at io.netty.util.concurrent.SingleThreadEventExecutor.addTask(SingleThreadEventExecutor.java:343)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:833)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute0(SingleThreadEventExecutor.java:824)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:814)
	at io.vertx.core.impl.EventLoopExecutor.execute(EventLoopExecutor.java:35)

⚙️ Native Tests - HTTP

📦 integration-tests/rest-client-reactive

io.quarkus.it.rest.client.BasicTestIT.shouldCreateClientSpans - History

  • expected: <1> but was: <2> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <1> but was: <2>
	at io.quarkus.it.rest.client.BasicTest.shouldCreateClientSpans(BasicTest.java:216)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:812)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@gsmet gsmet merged commit b547f76 into quarkusio:main Jul 25, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE area/platform Issues related to definition and interaction with Quarkus Platform area/qute The template engine area/reactive-messaging area/rest area/security area/smallrye area/spring Issues relating to the Spring integration area/testing triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants