-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distinguish non-instantiable build items #41909
Distinguish non-instantiable build items #41909
Conversation
Here you can find a list of Build Items and the extension that provides them: | ||
Here you can find a list of Build Items and the extension that provides them. | ||
|
||
icon:lock[title=Non-instantiatable Build Item] Build item can't be instantiated directly, but can be extended/inherited from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am unsure if a 🔒 is the best icon to represent this TBH. Maybe use 🏗️ or similar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went with the lock for a few reasons:
- I didn't know of any other one that would work OOTB in asciidoc :)
- Locked is kinda like abstract. It's locked, meaning can't be changed.
I can change to whatever
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're also constrained to the font-awesome library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7ffa66c
to
f55a493
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Do we want to merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a good addition. Let's merge this
@edeandrea can you resolve the conflicts? |
Who messed with my stuff? :D j/k i'll do that now |
Let me test and then squash now that i've resolved the conflicts |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
600cb27
to
0d37b12
Compare
In the all-builditems docs, use an icon/hover to distinguish non-instantiable build items. These can be extended by other build items, so documenting them is good.
This comment has been minimized.
This comment has been minimized.
6466da5
to
f9efa74
Compare
Ok formatting fixed. Everything squashed |
Status for workflow
|
Status for workflow
|
🙈 The PR is closed and the preview is expired. |
In the all-builditems docs, use an icon/hover to distinguish non-instantiable build items. These can be extended by other build items, so documenting them is good.
This came from https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/ContainerRuntime-.2C.20PodmanRuntime-.20and.20DockerStatusBuild.2E.2E.2E
cc: @holly-cummins @gastaldi @turing85