Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Dev UI ClassLoading to Runtime #41943

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

phillip-kruger
Copy link
Member

@phillip-kruger phillip-kruger commented Jul 17, 2024

@cescoffier - I had to pull in a new dependency in runtime module, that is not great.

Fix #41722

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

This comment has been minimized.

@cescoffier
Copy link
Member

@phillip-kruger which tests are failing?

@gsmet
Copy link
Member

gsmet commented Jul 17, 2024

Maybe some of the work needs to be done at build time? Or some info from the work done at build time passed to a recorder?

@phillip-kruger
Copy link
Member Author

@gsmet there are still a lot being done at build time. I have tried another way (creating all the objects and stubs during build time and just use them (via DevConsoleManager). However, to create the stubs you need the host and port, and those are runtime only config. So at this point if seems this PR is the way to go. I am sure the maintainers of this grpc extension might be able to do a better job than me (I don't know enough about grpc)

@phillip-kruger
Copy link
Member Author

@phillip-kruger which tests are failing?

Seems ok now. I had some local failures, but I might have been my environment ?

Copy link

quarkus-bot bot commented Jul 18, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 58137c3.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 17 Logs Raw logs 🚧
✔️ JVM Tests - JDK 21 Failures Logs Raw logs 🚧

Failures

⚙️ JVM Tests - JDK 21 #

- Failing: integration-tests/rest-client-reactive 

📦 integration-tests/rest-client-reactive

Failed to execute goal uk.co.automatictester:truststore-maven-plugin:3.0.0:generate-truststore (self-signed-truststore) on project quarkus-integration-test-rest-client-reactive: Execution self-signed-truststore of goal uk.co.automatictester:truststore-maven-plugin:3.0.0:generate-truststore failed: Unable to establish TLS connection with: self-signed.badssl.com:443


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 integration-tests/rest-client

io.quarkus.it.rest.client.trustall.ExternalTlsTrustAllTestCase.restClient - History

  • Read timed out - java.net.SocketTimeoutException
java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:288)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:314)
	at java.base/sun.nio.ch.NioSocketImpl.read(NioSocketImpl.java:355)
	at java.base/sun.nio.ch.NioSocketImpl$1.read(NioSocketImpl.java:808)
	at java.base/java.net.Socket$SocketInputStream.read(Socket.java:966)
	at org.apache.http.impl.io.AbstractSessionInputBuffer.fillBuffer(AbstractSessionInputBuffer.java:161)
	at org.apache.http.impl.io.SocketInputBuffer.fillBuffer(SocketInputBuffer.java:82)

📦 integration-tests/rest-client-reactive

io.quarkus.it.rest.client.wronghost.ExternalWrongHostTestCase.restClient - History

  • Read timed out - java.net.SocketTimeoutException
java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:288)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:314)
	at java.base/sun.nio.ch.NioSocketImpl.read(NioSocketImpl.java:355)
	at java.base/sun.nio.ch.NioSocketImpl$1.read(NioSocketImpl.java:808)
	at java.base/java.net.Socket$SocketInputStream.read(Socket.java:966)
	at org.apache.http.impl.io.AbstractSessionInputBuffer.fillBuffer(AbstractSessionInputBuffer.java:161)
	at org.apache.http.impl.io.SocketInputBuffer.fillBuffer(SocketInputBuffer.java:82)

⚙️ Native Tests - HTTP

📦 integration-tests/rest-client

io.quarkus.it.rest.client.trustall.ExternalTlsTrustAllIT.restClient - History

  • Read timed out - java.net.SocketTimeoutException
java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:288)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:314)
	at java.base/sun.nio.ch.NioSocketImpl.read(NioSocketImpl.java:355)
	at java.base/sun.nio.ch.NioSocketImpl$1.read(NioSocketImpl.java:808)
	at java.base/java.net.Socket$SocketInputStream.read(Socket.java:966)
	at org.apache.http.impl.io.AbstractSessionInputBuffer.fillBuffer(AbstractSessionInputBuffer.java:161)
	at org.apache.http.impl.io.SocketInputBuffer.fillBuffer(SocketInputBuffer.java:82)
  • Read timed out - java.net.SocketTimeoutException
java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:288)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:314)
	at java.base/sun.nio.ch.NioSocketImpl.read(NioSocketImpl.java:355)
	at java.base/sun.nio.ch.NioSocketImpl$1.read(NioSocketImpl.java:808)
	at java.base/java.net.Socket$SocketInputStream.read(Socket.java:966)
	at org.apache.http.impl.io.AbstractSessionInputBuffer.fillBuffer(AbstractSessionInputBuffer.java:161)
	at org.apache.http.impl.io.SocketInputBuffer.fillBuffer(SocketInputBuffer.java:82)

@cescoffier
Copy link
Member

@gsmet do you think you could check if this fix the leak you found around gRPC / Dev UI ?

@phillip-kruger
Copy link
Member Author

@cescoffier @gsmet I have check against the draft PR that @gsmet has ready and I can confirm this fix it.

@cescoffier cescoffier merged commit 4df50e4 into quarkusio:main Jul 19, 2024
36 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GrpcDevUIProcessor#grpcAction() is problematic from a CL point of view
3 participants