Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Oracle JDBC driver to 23.4.0.24.05 #41949

Closed
wants to merge 1 commit into from

Conversation

Felk
Copy link
Contributor

@Felk Felk commented Jul 17, 2024

I'm not entirely sure if it's okay to just do this, @Sanne might know since he did all the OJDBC updates so far.

This isn't a high priority for me, but it's nice if it finds its way into Quarkus eventually since it fixes #35070 (current workaround is an exclusion to manually upgrade to OJDBC 23.4)

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Jul 17, 2024
@Sanne
Copy link
Member

Sanne commented Jul 17, 2024

I'm not entirely sure if it's okay to just do this, @Sanne might know since he did all the OJDBC updates so far.

Totally! I missed this.

In the past I used to do them myself as we often needed to adjust some tricky aspects related to native-image metadata, but I don't expect that to be necessary anymore, and we have better integration tests that would spot such problems.

If it's accepted by CI we can upgrade.

Thanks a lot!

@Sanne Sanne added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 17, 2024
@Felk
Copy link
Contributor Author

Felk commented Jul 17, 2024

Looks like CI did not like the change afterall, and the errors look related to native image generation. I'm afraid debugging this is out of my current capabilities, but maybe you can take a look at the failed tests at your earliest convenience? 🙏

@gastaldi gastaldi removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 17, 2024
Copy link

quarkus-bot bot commented Jul 17, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit f66d2ba.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 17 Logs Raw logs 🔍
JVM Tests - JDK 21 Build Failures Logs Raw logs 🔍
Native Tests - Data2 Build Failures Logs Raw logs 🔍
Native Tests - Data7 Build Failures Logs Raw logs 🔍
Native Tests - Misc4 Build Failures Logs Raw logs 🔍

You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 21 #

- Failing: extensions/panache/mongodb-panache-kotlin/runtime 
! Skipped: extensions/panache/mongodb-panache-kotlin/deployment integration-tests/mongodb-panache-kotlin 

📦 extensions/panache/mongodb-panache-kotlin/runtime

Failed to execute goal org.apache.maven.plugins:maven-jar-plugin:3.3.0:jar (default-jar) on project quarkus-mongodb-panache-kotlin: Error assembling JAR


⚙️ Native Tests - Data2 #

- Failing: integration-tests/jpa-oracle 

📦 integration-tests/jpa-oracle

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-jpa-oracle: Failed to build quarkus application


⚙️ Native Tests - Data7 #

- Failing: integration-tests/reactive-oracle-client 

📦 integration-tests/reactive-oracle-client

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-reactive-oracle-client: Failed to build quarkus application


⚙️ Native Tests - Misc4 #

- Failing: integration-tests/opentelemetry-jdbc-instrumentation 

📦 integration-tests/opentelemetry-jdbc-instrumentation

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-opentelemetry-jdbc-instrumentation: Failed to build quarkus application


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 integration-tests/virtual-threads/grpc-virtual-threads

io.quarkus.grpc.example.streaming.VertxVirtualThreadTest.testStreamingOutputCall - History

  • INTERNAL: Half-closed without a request - io.grpc.StatusRuntimeException
io.grpc.StatusRuntimeException: INTERNAL: Half-closed without a request
	at io.grpc.Status.asRuntimeException(Status.java:533)
	at io.grpc.stub.ClientCalls$BlockingResponseStream.hasNext(ClientCalls.java:631)
	at java.base/java.util.Iterator.forEachRemaining(Iterator.java:132)
	at io.quarkus.grpc.example.streaming.VirtualThreadTestBase.testStreamingOutputCall(VirtualThreadTestBase.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:973)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:823)

@Sanne
Copy link
Member

Sanne commented Jul 18, 2024

No worries, I'll have a look.

@Sanne
Copy link
Member

Sanne commented Jul 19, 2024

Looks like the native-image metadata changed significantly again, but we should be able to fix it.

@tsegismont assuming I can sort it out, would you know if the upgrade would be a problem for the oracle pgclient?

cc/ @yrodiere

@tsegismont
Copy link
Contributor

@tsegismont assuming I can sort it out, would you know if the upgrade would be a problem for the oracle pgclient?

Let me check

@Sanne
Copy link
Member

Sanne commented Jul 19, 2024

Replaced by #41998 . Thanks again @Felk !

@Sanne Sanne closed this Jul 19, 2024
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Jul 19, 2024
@Felk Felk deleted the oracle_jdbc_23.4 branch July 19, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file triage/flaky-test triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oracle error ORA-01461 when persisting entity with special characters in absurdly specific circumstances
4 participants