Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid mixing @ConfigMapping and legacy @ConfigRoot in OIDC token propagation #42019

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jul 20, 2024

This is going to be a problem with the new extension annotation processor.

@michalvavrik could you have a look? I find it odd we are mixing the two approaches, especially since you are very thorough. Did you have a reason to keep the old @ConfigRoot pattern for the build time config? Maybe there was a limitation that got lifted? I ran the module tests and the module ITs and it was going fine.

@radcortez for sanity check

…agation

This is going to be a problem with the new extension annotation
processor.
Copy link

quarkus-bot bot commented Jul 20, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 160e95b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet requested a review from michalvavrik July 20, 2024 12:50
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the file history and can't find a good reason why I didn't make this a @ConfigMapping. I think I made mistake. Changes LGTM. Thanks

@gsmet
Copy link
Member Author

gsmet commented Jul 21, 2024

Yeah it's easy to miss them or to just move to the new format when creating new config.

From now on, we will need consistency inside a given module thus why the fix.

Thanks for the confirmation!

@geoand geoand merged commit 85603bd into quarkusio:main Jul 22, 2024
21 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants