Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite TLS test for the rest-client and reactive-rest-client #42042

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

cescoffier
Copy link
Member

  • Remove the trust store maven plugin which has not be super reliable recently on CI
  • Use the cert generator instead
  • Make sure the tests are not tainted with a quarkus.tls.trust-all=true

@cescoffier cescoffier requested a review from geoand July 22, 2024 14:25
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/rest-client labels Jul 22, 2024
@cescoffier cescoffier added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Jul 22, 2024

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Jul 23, 2024

CI looks suspicious.

- Remove the trust store maven plugin which has not be super reliable recently on CI
- Use the cert generator instead
- Make sure the tests are not tainted with a quarkus.tls.trust-all=true
- did not use the certificate annotation as the certificates are required to start the test resources, and it would require annotating all the test cases (as the order is undefined)
@cescoffier
Copy link
Member Author

Yes, the CI issue was related, as the certs were not created before the IT execution. I pushed an update that should fix this issue.

Copy link

quarkus-bot bot commented Jul 23, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8b15c3a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest.testOTelInjections - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest was not fulfilled within 5 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest was not fulfilled within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest.reset(OpenTelemetryInjectionsTest.java:26)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)

@cescoffier cescoffier merged commit 64f088e into quarkusio:main Jul 23, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 23, 2024
@cescoffier cescoffier deleted the rest-client-tls-test branch July 24, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/rest-client triage/flaky-test
Projects
Development

Successfully merging this pull request may close these issues.

3 participants