-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use generated hostname when shared network is enabled #42065
Conversation
2ac554a
to
6d0b723
Compare
Thanks for this! Do you have a sample project that exhibits the problem this PR is solving? |
@geoand simply add jib to mongodb-client quickstart and try to run IT tests with |
Thanks, I'll give it a shot soon |
Status for workflow
|
Ah sorry, I was too fast to merge as I was planning the backports. @geoand if something is wrong, please ping me and I'll revert it. |
If all is good, we can backport it to the upcoming 3.13. |
No problem, I'll check this tomorrow to be on the same side, but it's very likely the correct fix |
Ideally if you can get me the confirmation in the morning, that will be helpful for me to include it in 3.13.0 and make @cristianonicolai happier. |
Sure, I'll try in the morning |
Works like a charm |
Thanks for the confirmation! |
The hostname was fixed in quarkusio#42065 but when using a shared network and a container build, the application will connect directly to the container port so we shouldn't use the exposed port but the original one. Fixes quarkusio#42453
The hostname was fixed in quarkusio#42065 but when using a shared network and a container build, the application will connect directly to the container port so we shouldn't use the exposed port but the original one. Fixes quarkusio#42453
The hostname was fixed in quarkusio#42065 but when using a shared network and a container build, the application will connect directly to the container port so we shouldn't use the exposed port but the original one. Fixes quarkusio#42453 (cherry picked from commit e853d39)
The hostname was fixed in quarkusio#42065 but when using a shared network and a container build, the application will connect directly to the container port so we shouldn't use the exposed port but the original one. Fixes quarkusio#42453
When using MongoDB DevService and Jib container build, the generated connection-string to run integration tests points to localhost, ex:
QUARKUS_MONGODB_CONNECTION_STRING=mongodb://localhost:63109/test
. The container will fail to start sincelocalhost
is not the correct host for the MongoDB service. Instead, the shared network hostname should be used.