Update dev service docker image versions #42078

melloware · 2024-07-23T11:37:36Z

Fix #42045

geoand · 2024-07-23T11:41:25Z

LGTM, @loicmathieu @yrodiere do you want to take a look as well?

Thanks

yrodiere

LGTM, but we'll need an entry in the migration guide, similar to what I suggested in #41507 (comment)

build-parent/pom.xml

jedla97 · 2024-07-23T12:17:45Z

build-parent/pom.xml

        <oracle.image>docker.io/gvenzl/oracle-free:23-slim-faststart</oracle.image>
-        <mongo.image>docker.io/mongo:4.4</mongo.image>
+        <mongo.image>docker.io/mongo:7.0.12</mongo.image>


I think that 7.0 should be used as it seems to point to latest 7.0.x.

Tested it with docker run --name some-mongo -d mongo:7.0 and see that 7.0.12 version is used.

Push changed to 7.0

gsmet

I added a note here: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.14

loicmathieu

LGTM, no sure why we use a so old image for Mongo but I remember some issue with some images not available on arm64.

gsmet · 2024-07-23T21:48:04Z

Something changed in PostgreSQL, I would bet:

Caused by: org.flywaydb.core.internal.sqlscript.FlywaySqlScriptException: Script  failed
--------------
SQL State  : 42501
Error Code : 0
Message    : ERROR: permission denied for schema public
Location   :  ()
Line       : 1
Statement  : CREATE OR REPLACE FUNCTION f_my_constant() RETURNS integer LANGUAGE plpgsql as $func$ BEGIN return 100; END $func$

	at org.flywaydb.core.internal.sqlscript.DefaultSqlScriptExecutor.handleException(DefaultSqlScriptExecutor.java:256)
	at org.flywaydb.core.internal.sqlscript.DefaultSqlScriptExecutor.executeStatement(DefaultSqlScriptExecutor.java:217)
	at org.flywaydb.core.internal.sqlscript.DefaultSqlScriptExecutor.execute(DefaultSqlScriptExecutor.java:137)
	at org.flywaydb.core.FlywayExecutor.lambda$execute$1(FlywayExecutor.java:157)
	at org.flywaydb.core.internal.jdbc.JdbcConnectionFactory.openConnection(JdbcConnectionFactory.java:106)
	at org.flywaydb.core.internal.database.base.Database.<init>(Database.java:89)
	at org.flywaydb.database.postgresql.PostgreSQLDatabase.<init>(PostgreSQLDatabase.java:37)
	at org.flywaydb.database.postgresql.PostgreSQLDatabaseType.createDatabase(PostgreSQLDatabaseType.java:96)
	at org.flywaydb.core.FlywayExecutor.execute(FlywayExecutor.java:162)
	at org.flywaydb.core.Flyway.migrate(Flyway.java:164)
	at io.quarkus.flyway.runtime.FlywayRecorder.doStartActions(FlywayRecorder.java:136)
	at io.quarkus.deployment.steps.FlywayProcessor$startActions2099152139.deploy_0(Unknown Source)
	at io.quarkus.deployment.steps.FlywayProcessor$startActions2099152139.deploy(Unknown Source)
	... 8 more
Caused by: org.postgresql.util.PSQLException: ERROR: permission denied for schema public
	at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2725)
	at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2412)
	at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:371)
	at org.postgresql.jdbc.PgStatement.executeInternal(PgStatement.java:502)
	at org.postgresql.jdbc.PgStatement.execute(PgStatement.java:419)
	at org.postgresql.jdbc.PgStatement.executeWithFlags(PgStatement.java:341)
	at org.postgresql.jdbc.PgStatement.executeCachedSql(PgStatement.java:326)
	at org.postgresql.jdbc.PgStatement.executeWithFlags(PgStatement.java:302)
	at org.postgresql.jdbc.PgStatement.execute(PgStatement.java:297)
	at org.flywaydb.core.internal.jdbc.JdbcTemplate.executeStatement(JdbcTemplate.java:210)
	at org.flywaydb.core.internal.sqlscript.ParsedSqlStatement.execute(ParsedSqlStatement.java:88)
	at org.flywaydb.core.internal.sqlscript.DefaultSqlScriptExecutor.executeStatement(DefaultSqlScriptExecutor.java:212)

melloware · 2024-07-24T11:09:13Z

@gsmet i downgraded to PG 15 as it looks like Flyway only supports 15 for now: flyway/flyway#3743

melloware · 2024-07-24T18:45:06Z

I wonder if we have to update Flyway version too or i should just leave Postgres at 14?

jedla97 · 2024-07-24T23:11:15Z

@melloware looking at postgres release notes. They done

Remove PUBLIC creation permission on the public schema
Change the owner of the public schema to be the new pg_database_owner role

I think one of this is responsible for that error. Maybe it's the bug in Flyway.

geoand · 2024-07-25T06:30:37Z

I wonder if we have to update Flyway version too or i should just leave Postgres at 14?

I think we can do the latter as a first step

gsmet · 2024-07-25T07:03:06Z

Yeah I suspect we just have to update our tests to not use the public schema and to create a schema ourselves. It's good practice anyway.

So if you have time, please do it and upgrade to latest, I would expect it to work. If you don't, you can drop the PostgreSQL update.

melloware · 2024-07-25T11:15:56Z

For now @gsmet i backed up to 14. Should I open another ticket so we can track updating to PG 16?

gsmet · 2024-07-25T17:21:13Z

Sure: please add all the details about the problem we have with Flyway.

yrodiere · 2024-07-26T08:27:32Z

I suspect the failure to download Redis is unrelated. I rebased on main to trigger another run on a more up-to-date codebase... Let's see how it goes.

quarkus-bot · 2024-07-26T13:46:11Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit c00a410.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/opentelemetry

✖ io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest.testOTelInjections - History

Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest was not fulfilled within 5 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest was not fulfilled within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest.reset(OpenTelemetryInjectionsTest.java:26)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)

⚙️ JVM Tests - JDK 21

📦 integration-tests/opentelemetry

✖ io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest.testOTelInjections - History

Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest was not fulfilled within 5 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest was not fulfilled within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest.reset(OpenTelemetryInjectionsTest.java:26)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

📦 integration-tests/virtual-threads/grpc-virtual-threads

✖ io.quarkus.grpc.example.streaming.VertxVirtualThreadTest.testStreamingOutputCall - History

INTERNAL: Half-closed without a request - io.grpc.StatusRuntimeException

io.grpc.StatusRuntimeException: INTERNAL: Half-closed without a request
	at io.grpc.Status.asRuntimeException(Status.java:533)
	at io.grpc.stub.ClientCalls$BlockingResponseStream.hasNext(ClientCalls.java:631)
	at java.base/java.util.Iterator.forEachRemaining(Iterator.java:132)
	at io.quarkus.grpc.example.streaming.VirtualThreadTestBase.testStreamingOutputCall(VirtualThreadTestBase.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:973)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:823)

⚙️ Maven Tests - JDK 17 Windows

📦 integration-tests/maven

✖ io.quarkus.maven.it.TestMojoIT.testThatTheTestsAreReRunMultiModule - History

Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils.waitForNextCompletion(TestModeContinuousTestingMavenTestUtils.java:50)
	at io.quarkus.maven.it.LaunchMojoTestBase.testThatTheTestsAreReRunMultiModule(LaunchMojoTestBase.java:56)

yrodiere · 2024-07-26T13:51:47Z

Merged, thanks!

FTR, the issue about Postgres 16: #42149

quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devservices labels Jul 23, 2024

melloware mentioned this pull request Jul 23, 2024

Dev services use Mongodb 4.4 which is EOL #42045

Closed

yrodiere reviewed Jul 23, 2024

View reviewed changes

build-parent/pom.xml Outdated Show resolved Hide resolved

build-parent/pom.xml Outdated Show resolved Hide resolved

build-parent/pom.xml Outdated Show resolved Hide resolved

jedla97 reviewed Jul 23, 2024

View reviewed changes

build-parent/pom.xml Outdated Show resolved Hide resolved

melloware force-pushed the patch-1 branch from 6851cce to 23442f6 Compare July 23, 2024 12:11

melloware requested a review from jedla97 July 23, 2024 12:12

jedla97 reviewed Jul 23, 2024

View reviewed changes

melloware force-pushed the patch-1 branch from 23442f6 to 67f54c1 Compare July 23, 2024 12:18

jedla97 approved these changes Jul 23, 2024

View reviewed changes

gsmet approved these changes Jul 23, 2024

View reviewed changes

loicmathieu approved these changes Jul 23, 2024

View reviewed changes

geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 23, 2024

This comment has been minimized.

Sign in to view

quarkus-bot bot added the triage/flaky-test label Jul 23, 2024

melloware force-pushed the patch-1 branch from 67f54c1 to b1f25bb Compare July 24, 2024 11:08

yrodiere approved these changes Jul 24, 2024

View reviewed changes

fedinskiy mentioned this pull request Jul 24, 2024

QQE-823 | Update image versions quarkus-qe/quarkus-test-suite#1904

Merged

9 tasks

This comment has been minimized.

Sign in to view

melloware force-pushed the patch-1 branch from b1f25bb to 727909b Compare July 25, 2024 11:15

fedinskiy mentioned this pull request Jul 25, 2024

QQE-823 | Updates used images quarkus-qe/quarkus-test-framework#1230

Merged

11 tasks

melloware mentioned this pull request Jul 25, 2024

Upgrade Postgres 16 #42149

Closed

3 tasks

This comment has been minimized.

Sign in to view

Update dev service docker image versions

c00a410

yrodiere force-pushed the patch-1 branch from 727909b to c00a410 Compare July 26, 2024 08:26

yrodiere merged commit 7e8c405 into quarkusio:main Jul 26, 2024
52 checks passed

quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jul 26, 2024

quarkus-bot bot added this to the 3.14 - main milestone Jul 26, 2024

melloware deleted the patch-1 branch July 26, 2024 14:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dev service docker image versions #42078

Update dev service docker image versions #42078

melloware commented Jul 23, 2024

geoand commented Jul 23, 2024

yrodiere left a comment

jedla97 Jul 23, 2024

melloware Jul 23, 2024

gsmet left a comment

loicmathieu left a comment

This comment has been minimized.

gsmet commented Jul 23, 2024

melloware commented Jul 24, 2024

This comment has been minimized.

melloware commented Jul 24, 2024

jedla97 commented Jul 24, 2024

geoand commented Jul 25, 2024

gsmet commented Jul 25, 2024

melloware commented Jul 25, 2024

gsmet commented Jul 25, 2024

This comment has been minimized.

yrodiere commented Jul 26, 2024

quarkus-bot bot commented Jul 26, 2024 •

edited by github-actions bot

Loading

yrodiere commented Jul 26, 2024

Update dev service docker image versions #42078

Update dev service docker image versions #42078

Conversation

melloware commented Jul 23, 2024

geoand commented Jul 23, 2024

yrodiere left a comment

Choose a reason for hiding this comment

jedla97 Jul 23, 2024

Choose a reason for hiding this comment

melloware Jul 23, 2024

Choose a reason for hiding this comment

gsmet left a comment

Choose a reason for hiding this comment

loicmathieu left a comment

Choose a reason for hiding this comment

This comment has been minimized.

gsmet commented Jul 23, 2024

melloware commented Jul 24, 2024

This comment has been minimized.

melloware commented Jul 24, 2024

jedla97 commented Jul 24, 2024

geoand commented Jul 25, 2024

gsmet commented Jul 25, 2024

melloware commented Jul 25, 2024

gsmet commented Jul 25, 2024

This comment has been minimized.

yrodiere commented Jul 26, 2024

quarkus-bot bot commented Jul 26, 2024 • edited by github-actions bot Loading

Status for workflow Quarkus CI

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/opentelemetry

⚙️ JVM Tests - JDK 21

📦 integration-tests/opentelemetry

📦 integration-tests/virtual-threads/grpc-virtual-threads

⚙️ Maven Tests - JDK 17 Windows

📦 integration-tests/maven

yrodiere commented Jul 26, 2024

quarkus-bot bot commented Jul 26, 2024 •

edited by github-actions bot

Loading

Status for workflow `Quarkus CI`