Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Oracle JDBC driver 23.5 #42334

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

Felk
Copy link
Contributor

@Felk Felk commented Aug 6, 2024

Trying my luck again, hoping no metadata has changed this time and CI passes without any modifications. For reference, previous upgrade was #41998

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Aug 6, 2024
@gsmet
Copy link
Member

gsmet commented Aug 6, 2024

Please monitor CI on your fork, I'll start CI here if things are all good on your side. Thanks!

@Felk
Copy link
Contributor Author

Felk commented Aug 7, 2024

Here are the results (Status: success): https://github.com/Felk/quarkus/actions/runs/10267101277

@gsmet
Copy link
Member

gsmet commented Aug 7, 2024

Perfect, thanks!

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 7, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 97dba8c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.MetricsTest.directCounterTest - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.MetricsTest.directCounterTest(MetricsTest.java:54)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

@gsmet
Copy link
Member

gsmet commented Aug 7, 2024

And merged!

@gsmet gsmet merged commit 3be2c10 into quarkusio:main Aug 7, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Aug 7, 2024
@Felk Felk deleted the oracle_jdbc_23.5 branch August 7, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants