-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore Kotlin compiler generated annotations during live reload #42363
Conversation
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
8991414
to
594ccc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. I added a small suggestion inline.
static Set<DotName> ignores = new HashSet<>(); | ||
|
||
static { | ||
ignores.add(DotName.createSimple("kotlin.jvm.internal.SourceDebugExtension")); | ||
ignores.add(DotName.createSimple("kotlin.Metadata")); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be simplified to the following and made private (and you would need to adjust the name below):
static Set<DotName> ignores = new HashSet<>(); | |
static { | |
ignores.add(DotName.createSimple("kotlin.jvm.internal.SourceDebugExtension")); | |
ignores.add(DotName.createSimple("kotlin.Metadata")); | |
} | |
private static final Set<DotName> IGNORED_ANNOTATIONS = Set.of(DotName.createSimple("kotlin.jvm.internal.SourceDebugExtension"), DotName.createSimple("kotlin.Metadata")); | |
LGTM! Could you squash the two commits and force push? I can do it you're not familiar with it. Thanks! |
c783cb5
to
a9d3f36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This comment has been minimized.
This comment has been minimized.
instrument live-reload will compare class structure to make sure this class can be "redefine" But the classes generated by Kotlin compiler contains debug annotations, the comparison always fail. Exclude the annotations which generated by Kotlin compiler.
a9d3f36
to
28f062d
Compare
I fixed the formatting issue and force pushed. Let's wait for CI and merge. |
I have this alias that is handy to format the Quarkus source code:
|
Status for workflow
|
Instrument live-reload will compare class structure to make sure this class can be "redefine".
But the classes generated by Kotlin compiler contains debug annotations, the comparison always fail.
Exclude the annotations which generated by Kotlin compiler.