-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly handle case when quarkus-extension.yaml doesn't exist #42561
Conversation
We need to catch the NoSuchFileException and ignore it. Per gripe from Marco Bungart in the Quarkus Artemis project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea
This comment has been minimized.
This comment has been minimized.
Nice! Thanks for the fast fix 🙂 |
Status for workflow
|
🎊 PR Preview 1466fcc has been successfully built and deployed to https://quarkus-pr-main-42561-preview.surge.sh/version/main/guides/
|
Status for workflow
|
For some reason, when I run any of my unit tests inside IntelliJ, I get the following warning:
In the pom.xml file of my application I have the following to generate the application documentation: <plugin>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-config-doc-maven-plugin</artifactId>
<version>${quarkus.version}</version>
<extensions>true</extensions>
<executions>
<execution>
<id>default-generate-asciidoc</id>
<phase>process-test-resources</phase>
<goals>
<goal>generate-asciidoc</goal>
</goals>
</execution>
</executions>
</plugin>
...
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-extension-processor</artifactId>
<version>${quarkus.version}</version>
</dependency> Not sure why it's a The warning doesn't show up with maven in command-line though, so I suspect IntelliJ is doing something to the classpath. Any ideas? Would it make sense to also catch and ignore Thanks! |
The |
Yes, I'm aware 😄 I followed those instructions by @radcortez and it worked until Quarkus 3.13. With 3.14, the asciidoc generation has been moved to I realize this documentation mechanism was intended for quarkus extensions and wasn't intended for applications but it's really useful to generate the documentation as it is less error prone than to maintain it manually. |
#42853 should take care of your issues. I'll backport it to 3.14.2. Thanks for reporting! |
Related to quarkusio#42561 (comment) (cherry picked from commit 68d78a2)
Related to quarkusio#42561 (comment) (cherry picked from commit 68d78a2)
We need to catch the NoSuchFileException and ignore it.
Per gripe from Marco Bungart in the Quarkus Artemis project.