Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Infinispan 15.0.8.Final #42702

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

karesti
Copy link
Member

@karesti karesti commented Aug 22, 2024

Latest stable

  • SSL config validation is avoided by not starting the client
  • Adds keyStore missing configuration
  • Adds a property to disable client start if needed

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/infinispan Infinispan labels Aug 22, 2024
@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Aug 24, 2024

@karesti this update doesn't look good.

@karesti
Copy link
Member Author

karesti commented Aug 27, 2024

@gsmet weird, let me test locally again

* SSL config validation is avoided by not starting the client
* Adds keyStore missing configuration
* Adds a property to disable client start if needed
@karesti karesti force-pushed the update-infinispan-15.0.8.Final branch from b2f27a2 to 7e81c80 Compare August 27, 2024 18:04
@karesti
Copy link
Member Author

karesti commented Aug 27, 2024

@gsmet

When I was in PTO, Infinispan 15.0.7.Final introduced a change that validates earlier the SSL configuration when we create and start a RemoteCacheManager.
infinispan/infinispan@b91ab65

I forgot to run some unit tests locally, and one failed. The failing test creates the client and ensures we are correctly passing the settings from Quarkus properties to Infinispan. However, since we don’t actually need to start the client or server to verify this, I added a property that lets us skip starting the client. This change might be useful in other situations too, and it’s part of the Infinispan public API.

I also noticed that the keyStore properties weren’t being mapped to the client, so I fixed that as well.

Copy link

🎊 PR Preview 08c3013 has been successfully built and deployed to https://quarkus-pr-main-42702-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 27, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 7e81c80.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 27, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 28, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7e81c80.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gastaldi gastaldi merged commit a169975 into quarkusio:main Aug 28, 2024
53 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Aug 28, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 28, 2024
@karesti karesti deleted the update-infinispan-15.0.8.Final branch August 28, 2024 08:24
@gsmet gsmet modified the milestones: 3.16 - main, 3.14.2 Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/infinispan Infinispan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants