Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use initial Quarkus Dev config for test tags and engines #42766

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented Aug 26, 2024

It worked before because

testSupport.setTags(config.includeTags.orElse(Collections.emptyList()),
config.excludeTags.orElse(Collections.emptyList()));
testSupport.setPatterns(config.includePattern.orElse(null),
config.excludePattern.orElse(null));
testSupport.setEngines(config.includeEngines.orElse(Collections.emptyList()),
config.excludeEngines.orElse(Collections.emptyList()));
testSupport.setConfiguredDisplayTestOutput(config.displayTestOutput);
testSupport.setTestType(config.type);
sets the tags and engines config from the Quarkus Dev config (which includes the configuration coming from the build system).

With the change in #41317, handleApplicationPropertiesChange now sets the reading properties to empty List instead of null, which makes Object.equals to behave differently and override the configuration.

For now, let's fallback to the configuration set by TestTracingProcessor, but the goal is to improve this.

Related to:

@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 27, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 39d19cc.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit 3304163 into quarkusio:main Aug 27, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Aug 27, 2024
TestType testType = updatedConfig.getOptionalValue("quarkus.test.type", TestType.class).orElse(TestType.ALL);

if (!firstRun) {
if (!Objects.equals(includeTags, appPropertiesIncludeTags)) {
this.includeTags = includeTags;
this.includeTags = Objects.requireNonNullElse(includeTags, Collections.emptyList());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged it but in the future, let's use List.of() for empty lists (no need to update it here, it's just a comment for future patches). Thanks!

@gsmet gsmet modified the milestones: 3.16 - main, 3.14.2 Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continuous testing exclude-tags or exclude-engines cannot be configured via pom.xml anymore in 3.13
2 participants