Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly set PoolOptions for REST Client #42823

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Properly set PoolOptions for REST Client #42823

merged 1 commit into from
Aug 28, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Aug 28, 2024 •
edited
Loading

@geoand geoand mentioned this pull request Aug 28, 2024
Closed
@geoand geoand requested a review from cescoffier August 28, 2024 07:05
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 28, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 45d0d25.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

gsmet
gsmet reviewed Aug 28, 2024
View reviewed changes
...eactive/client/runtime/src/main/java/org/jboss/resteasy/reactive/client/impl/ClientImpl.java
@@ -192,7 +192,7 @@ public Vertx get() {
options.setShared(true);
}

var httpClientBuilder = this.vertx.httpClientBuilder().with(options);
var httpClientBuilder = this.vertx.httpClientBuilder().with(options).with(options.getPoolOptions());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it expected that the nested options are not applied by Vert.x? I would expect all the nested options to be applied when you do with(options)?

Especially since the nested structure is completely hidden from you.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other words, while I'm all for a quick fix, I wonder if it's not a bug in Vert.x itself?

Copy link
Contributor Author

@geoand geoand Aug 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a totally legitimate quetion which I also asked @cescoffier in chat before applying this.

For now let's get it in and we can figure later out if we need to update Vert.x itself

@geoand geoand merged commit dc07fa6 into quarkusio:main Aug 28, 2024
32 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Aug 28, 2024
@gsmet
Copy link
Member

gsmet commented Aug 28, 2024

Yeah I totally agree we should merge and backport it.

@geoand geoand deleted the #42778 branch August 28, 2024 10:23
@gsmet gsmet mentioned this pull request Aug 29, 2024
Closed
@gsmet gsmet modified the milestones: 3.16 - main, 3.14.2 Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet left review comments

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/rest-client kind/bugfix
Projects
None yet
Milestone
3.14.2
Development

Successfully merging this pull request may close these issues.

Rest Client (formerly reactive) keep using DEFAULT_MAX_POOL_SIZE
3 participants
@geoand @gsmet @cescoffier