-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArC - static methods interception: fix the set of copied annotations #42833
Conversation
mkouba
commented
Aug 28, 2024
- also only consider annotations with RetentionPolicy.RUNTIME because AnnotatedElement#addAnnotation(AnnotationInstance) does not reflect the original RetentionPolicy
- fixes Duplicate annotation for class: interface org.jetbrains.annotations.NotNull #42828
@geoand it would be great if you could this PR with your simplified reproducer. |
- also only consider annotations with RetentionPolicy.RUNTIME because AnnotatedElement#addAnnotation(AnnotationInstance) does not reflect the original RetentionPolicy - fixes quarkusio#42828
Works as advertised, thanks! |
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs | Build scan |
---|---|---|---|---|---|---|
✖ | JVM Tests - JDK 17 | Build |
Failures | Logs | Raw logs | 🔍 |
✖ | JVM Tests - JDK 21 | Build |
Failures | Logs | Raw logs | 🔍 |
✖ | JVM Tests - JDK 17 Windows | Build |
Failures | Logs | Raw logs | 🔍 |
Full information is available in the Build summary check run.
You can consult the Develocity build scans.
Failures
⚙️ JVM Tests - JDK 17 #
- Failing: integration-tests/grpc-cli
📦 integration-tests/grpc-cli
✖ io.quarkus.grpc.cli.GrpcCliTest.testCommand
- History - More details - Source on GitHub
java.lang.RuntimeException:
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.vertx.http.deployment.VertxHttpProcessor#cors threw an exception: java.lang.IllegalStateException: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
at io.quarkus.deployment.proxy.ProxyFactory.newInstance(ProxyFactory.java:281)
at io.quarkus.deployment.recording.BytecodeRecorderImpl.getProxyInstance(BytecodeRecorderImpl.java:409)
at io.quarkus.deployment.recording.BytecodeRecorderImpl$1.invoke(BytecodeRecorderImpl.java:351)
at io.quarkus.deployment.recording.BytecodeRecorderImpl$$RecordingProxyProxy13.corsHandler(Unknown Source)
at io.quarkus.vertx.http.deployment.VertxHttpProcessor.cors(VertxHttpProcessor.java:169)
⚙️ JVM Tests - JDK 21 #
- Failing: integration-tests/grpc-cli
📦 integration-tests/grpc-cli
✖ io.quarkus.grpc.cli.GrpcCliTest.testCommand
- History - More details - Source on GitHub
java.lang.RuntimeException:
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.vertx.http.deployment.VertxHttpProcessor#cors threw an exception: java.lang.IllegalStateException: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
at io.quarkus.deployment.proxy.ProxyFactory.newInstance(ProxyFactory.java:281)
at io.quarkus.deployment.recording.BytecodeRecorderImpl.getProxyInstance(BytecodeRecorderImpl.java:409)
at io.quarkus.deployment.recording.BytecodeRecorderImpl$1.invoke(BytecodeRecorderImpl.java:351)
at io.quarkus.deployment.recording.BytecodeRecorderImpl$$RecordingProxyProxy33.corsHandler(Unknown Source)
at io.quarkus.vertx.http.deployment.VertxHttpProcessor.cors(VertxHttpProcessor.java:169)
⚙️ JVM Tests - JDK 17 Windows #
- Failing: integration-tests/grpc-cli
📦 integration-tests/grpc-cli
✖ io.quarkus.grpc.cli.GrpcCliTest.testCommand
- History - More details - Source on GitHub
java.lang.RuntimeException:
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.vertx.http.deployment.VertxHttpProcessor#cors threw an exception: java.lang.IllegalStateException: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
at io.quarkus.deployment.proxy.ProxyFactory.newInstance(ProxyFactory.java:281)
at io.quarkus.deployment.recording.BytecodeRecorderImpl.getProxyInstance(BytecodeRecorderImpl.java:409)
at io.quarkus.deployment.recording.BytecodeRecorderImpl$1.invoke(BytecodeRecorderImpl.java:351)
at io.quarkus.deployment.recording.BytecodeRecorderImpl$$RecordingProxyProxy27.corsHandler(Unknown Source)
at io.quarkus.vertx.http.deployment.VertxHttpProcessor.cors(VertxHttpProcessor.java:169)
Flaky tests - Develocity
⚙️ JVM Tests - JDK 17
📦 extensions/hibernate-orm/deployment
✖ io.quarkus.hibernate.orm.HibernateHotReloadDevModeTest.testImportSqlWithContinuousTesting
- History
Failed to wait for test run 3 State{lastRun=1, running=true, inProgress=false, run=1, passed=1, failed=0, skipped=0, isBrokenOnly=false, isTestOutput=false, isInstrumentationBasedReload=false, isLiveReload=true}
-org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Failed to wait for test run 3 State{lastRun=1, running=true, inProgress=false, run=1, passed=1, failed=0, skipped=0, isBrokenOnly=false, isTestOutput=false, isInstrumentationBasedReload=false, isLiveReload=true}
at io.quarkus.test.ContinuousTestingTestUtils.waitForNextCompletion(ContinuousTestingTestUtils.java:44)
at io.quarkus.hibernate.orm.HibernateHotReloadDevModeTest.testImportSqlWithContinuousTesting(HibernateHotReloadDevModeTest.java:89)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: org.awaitility.core.ConditionTimeoutException: Condition returned by method "waitForNextCompletion" in class io.quarkus.test.ContinuousTestingTestUtils was not fulfilled within 1 minutes.
at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
The |