Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config Doc - Fix two scanning issues #42835

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Config Doc - Fix two scanning issues #42835

merged 2 commits into from
Aug 28, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Aug 28, 2024

The second commit fixes #42815 . The first one, I'm not sure it actually causes issues in the wild but we need it for correctness.

@gsmet
Config Doc - Always scan the superclass and interfaces
0586a0c 
Several config roots can share the same super class or interface so we
need to scan them always as the content of the scan will be attached to
the root element.
@gsmet
Config Doc - Scan config groups that are outside of the module
5464841 
For traditional config roots, we also need to scan the potential config
groups that are not in this module.

Fixes quarkusio#42815
@gsmet gsmet mentioned this pull request Aug 28, 2024
Closed
@github-actions GitHub Actions
Copy link

🎊 PR Preview 58c2eb5 has been successfully built and deployed to https://quarkus-pr-main-42835-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 28, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 5464841.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@gsmet gsmet requested a review from gastaldi August 28, 2024 13:48
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 28, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 5464841.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/micrometer/deployment

✖ io.quarkus.micrometer.deployment.binder.VertxTcpMetricsTest.testTcpMetrics - History

  • event executor terminated - java.util.concurrent.RejectedExecutionException
java.util.concurrent.RejectedExecutionException: event executor terminated
	at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:931)
	at io.netty.util.concurrent.SingleThreadEventExecutor.offerTask(SingleThreadEventExecutor.java:350)
	at io.netty.util.concurrent.SingleThreadEventExecutor.addTask(SingleThreadEventExecutor.java:343)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:833)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute0(SingleThreadEventExecutor.java:824)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:814)
	at io.vertx.core.impl.EventLoopExecutor.execute(EventLoopExecutor.java:35)

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.CompileOnlyDependencyDevModeTest.main - History

  • Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 2 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 2 minutes.
	at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at app//io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at app//io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:164)

@gastaldi gastaldi merged commit 7e86ad8 into quarkusio:main Aug 28, 2024
54 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Aug 28, 2024
@gsmet gsmet modified the milestones: 3.16 - main, 3.14.2 Aug 30, 2024
@gsmet gsmet mentioned this pull request Sep 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@sberyozkin sberyozkin sberyozkin approved these changes

Assignees
No one assigned
Labels
area/core kind/bugfix triage/flaky-test
Projects
None yet
Milestone
3.14.2
Development

Successfully merging this pull request may close these issues.

The configuration options missing the quarkus.oidc.credentials.*
3 participants
@gsmet @gastaldi @sberyozkin