Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image properties applied on gradle task configuration #42934

Closed
wants to merge 1 commit into from

Conversation

Malandril
Copy link
Contributor

@Malandril Malandril commented Sep 1, 2024

Set the tasks's forcedProperties on task execution rather than task configuration.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Sep 1, 2024
@Malandril Malandril changed the title Fix image properties applied on task configuration Fix image properties applied on gradle task configuration Sep 1, 2024
@geoand geoand requested a review from iocanel September 2, 2024 09:04
Copy link

quarkus-bot bot commented Sep 2, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit a25cab5.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

gsmet
gsmet previously approved these changes Sep 2, 2024
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the issue and the fix, I think it makes a lot of sense.

I will merge tomorrow except if someone complain about it.

@gsmet
Copy link
Member

gsmet commented Sep 2, 2024

@Malandril that being said, I wonder if your problem wouldn't be solved by this (more involved) patch: https://github.com/quarkusio/quarkus/pull/42875/files .

Could you have a look at it and test it?

@gsmet gsmet dismissed their stale review September 2, 2024 16:24

Let's wait for the decision about the other patch.

@Malandril
Copy link
Contributor Author

Malandril commented Sep 2, 2024

@Malandril that being said, I wonder if your problem wouldn't be solved by this (more involved) patch: https://github.com/quarkusio/quarkus/pull/42875/files .

Could you have a look at it and test it?

It works well ! And with the configuration cache too.
You can close this PR in favour of #42875 if it is to be merged

@gsmet
Copy link
Member

gsmet commented Sep 3, 2024

Perfect, thanks for checking! I think we will favor the more complete PR.

@gsmet gsmet closed this Sep 3, 2024
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Sep 3, 2024
@Malandril Malandril deleted the fix-gradle-image-42256 branch September 6, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle early task configuration causes quarkus.container-image. properties to be ignored
2 participants