Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note on JsonFormat annotation and ORM FormatMapper #43234

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

marko-bekhta
Copy link
Contributor

So that there's a slightly better chance that the correct annotation is used and not the com.fasterxml.jackson.annotation.JsonFormat one.

Copy link

github-actions bot commented Sep 12, 2024

🙈 The PR is closed and the preview is expired.

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 12, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit a1c4c20.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This begs the question: should we rename this annotation, if its current name is confusing?

But in the meantime, I agree this is better.

@gsmet gsmet merged commit 98ab61c into quarkusio:main Sep 12, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 12, 2024
@gsmet gsmet modified the milestones: 3.16 - main, 3.15.0 Sep 13, 2024
@gsmet gsmet modified the milestones: 3.15.0, 3.14.4 Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants