Make KafkaStreams health checks async #43294
Conversation
PhilKes
commented
Sep 14, 2024
•
PhilKes
commented
- Closes: Kafka Streams: use non-blocking health checks #42882
|
|
||
| @Readiness | ||
| @ApplicationScoped | ||
| public class KafkaStreamsTopicsHealthCheck implements HealthCheck { | ||
| public class KafkaStreamsTopicsHealthCheck implements AsyncHealthCheck { |
There was a problem hiding this comment.
I actually don't think this is going to work properly because KafkaStreamsTopicsHealthCheck makes a blocking call to listTopics
There was a problem hiding this comment.
You're right of course, I guess the Uni.createFrom().item should enclose the entire method body to make it asynchronous. Pushed the changes (+ squashed).
There was a problem hiding this comment.
Thanks. I'll let @ozangunalp take it from here
There was a problem hiding this comment.
This is not as easy as it seems. We do not have a reactive Kafka Admin client checking required topics on the broker. So this health check is inherently blocking. Wrapping it in Uni doesn't make it reactive, unfortunately.
And even though we'd transformed it to reactive I don't think it'll resolve the referenced issue.
We may discuss however, to move the Kafka Streams topics check from readiness to startup. That would help with the pods getting killed.
This comment has been minimized.
This comment has been minimized.
PhilKes
force-pushed
the
kafka-streams-async-health-check
branch
from
a52f265
to
81844b4
Compare
