Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build item for extensions to contribute ClusterRoleBindings #43378

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

metacosm
Copy link
Contributor

Signed-off-by: Chris Laprun claprun@redhat.com

@metacosm
Copy link
Contributor Author

This would also be a candidate for backport if possible.

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Sep 25, 2024

Is there an overall goal behind the backport requests?

Because from what I can see, this one (and some of the others) qualify more as new features than as fixes. So except if we have a very pressing business requirements, I'm not so excited about backporting them.

@metacosm
Copy link
Contributor Author

Is there an overall goal behind the backport requests?

Because from what I can see, this one (and some of the others) qualify more as new features than as fixes. So except if we have a very pressing business requirements, I'm not so excited about backporting them.

Understandable. However, quarkiverse/quarkus-operator-sdk#932 cannot be fixed without these particular features (or changes that would similarly expose information that isn't currently available to extensions). I wouldn't say that this is a pressing need, however it would be detrimental for this not to be in the next LTS, in my opinion. I realize it's pretty late in the cycle but we don't get to choose when issues appear or when we finally have time to work on them. This being available in some .x version of the next LTS would be fine with me, it doesn't need to be in the very first one as long as it's eventually there and doesn't have to wait for LTS + 1.

Signed-off-by: Chris Laprun <claprun@redhat.com>
Copy link

quarkus-bot bot commented Oct 9, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c114498.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

  • Expecting actual: ["-4","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"] - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual:
  ["-4","-5","-6","-7","-8","-9","-10","-11"]
to start with:
  ["-3", "-4", "-5", "-6"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)

Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iocanel iocanel merged commit 60f4210 into quarkusio:main Oct 10, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Oct 10, 2024
@metacosm metacosm deleted the add-crb-bi branch October 10, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants