-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply improvements to error handler page #43641
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Very cool ! Any reason this is still in Draft ? |
Thank you @phillip-kruger, I am adding view mode toggle |
5f390fd
to
9eb2d47
Compare
Hello @gsmet and @phillip-kruger, I added the change view mode function. (I updated the video) |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
I required some small changes (sorry but when dealing with UI/UX, there's always a lot of nitpicking).
Also, I think the test failure might be related. Maybe the test needs some adjustments due to the changes made, I don't know.
core/runtime/src/main/java/io/quarkus/runtime/TemplateHtmlBuilder.java
Outdated
Show resolved
Hide resolved
core/runtime/src/main/java/io/quarkus/runtime/TemplateHtmlBuilder.java
Outdated
Show resolved
Hide resolved
core/runtime/src/main/java/io/quarkus/runtime/TemplateHtmlBuilder.java
Outdated
Show resolved
Hide resolved
Thank you @gsmet, I am updating the pull request... tests are failling because HtmlUnit does not support |
9eb2d47
to
d353429
Compare
d353429
to
4b507b1
Compare
4b507b1
to
da69913
Compare
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICS, the intent looks good from my POV now, thanks!
@phillip-kruger I let you do a final check as quite some code has changed since you first reviewed.
Why
This pull request was created after this pull request discussion.
What
I am adding:
final.webm
Closes #43642