Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply improvements to error handler page #43641

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

mcruzdev
Copy link
Contributor

@mcruzdev mcruzdev commented Oct 2, 2024

Why

This pull request was created after this pull request discussion.

What

I am adding:

  • copy to clipboard button, to copy the stacktrace
final.webm
  • change the view mode (wrap and scroll)

image

Closes #43642

This comment was marked as resolved.

@phillip-kruger
Copy link
Member

Very cool ! Any reason this is still in Draft ?

@mcruzdev
Copy link
Contributor Author

mcruzdev commented Oct 2, 2024

Thank you @phillip-kruger, I am adding view mode toggle

@mcruzdev mcruzdev marked this pull request as ready for review October 2, 2024 16:40
@mcruzdev
Copy link
Contributor Author

mcruzdev commented Oct 2, 2024

Hello @gsmet and @phillip-kruger, I added the change view mode function. (I updated the video)

This comment has been minimized.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

I required some small changes (sorry but when dealing with UI/UX, there's always a lot of nitpicking).

Also, I think the test failure might be related. Maybe the test needs some adjustments due to the changes made, I don't know.

@mcruzdev
Copy link
Contributor Author

mcruzdev commented Oct 3, 2024

Nice work!

I required some small changes (sorry but when dealing with UI/UX, there's always a lot of nitpicking).

Also, I think the test failure might be related. Maybe the test needs some adjustments due to the changes made, I don't know.

Thank you @gsmet, I am updating the pull request... tests are failling because HtmlUnit does not support async functions...

Copy link

quarkus-bot bot commented Oct 4, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit da69913.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICS, the intent looks good from my POV now, thanks!

@phillip-kruger I let you do a final check as quite some code has changed since you first reviewed.

@phillip-kruger phillip-kruger merged commit 08a9bc0 into quarkusio:main Oct 7, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Oct 7, 2024
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Oct 7, 2024
@mcruzdev mcruzdev deleted the error-handler branch October 11, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Quarkus error page handler
3 participants