Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute: fix evaluation of section parameters #43875

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Oct 15, 2024

- iterators of a HashMap#entrySet() are not guaranteed to be consistent;
even if no modifications are made to the map
- this issue was discovered by @mohitbadve with the
https://github.com/TestingResearchIllinois/NonDex project
- supersedes http://github.com/quarkusio/quarkus/pull/43820
@quarkus-bot quarkus-bot bot added the area/qute The template engine label Oct 15, 2024
Copy link

quarkus-bot bot commented Oct 15, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 3b81167.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 integration-tests/virtual-threads/grpc-virtual-threads

io.quarkus.grpc.example.streaming.VertxVirtualThreadTest.testUnary - History

  • INTERNAL: Half-closed without a request - io.grpc.StatusRuntimeException
io.grpc.StatusRuntimeException: INTERNAL: Half-closed without a request
	at io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:268)
	at io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:249)
	at io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:167)
	at io.grpc.testing.integration.TestServiceGrpc$TestServiceBlockingStub.unaryCall(TestServiceGrpc.java:220)
	at io.quarkus.grpc.example.streaming.VirtualThreadTestBase.testUnary(VirtualThreadTestBase.java:33)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:971)

@gastaldi gastaldi merged commit 6c67d81 into quarkusio:main Oct 15, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Oct 15, 2024
@gsmet gsmet modified the milestones: 3.16.0.CR1, 3.15.3 Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants