Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also use args when comparing test resources #44215

Closed
wants to merge 1 commit into from

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Oct 31, 2024

This comment has been minimized.

Copy link

quarkus-bot bot commented Oct 31, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 1c4e038.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/oidc-client-wiremock

io.quarkus.it.keycloak.OidcClientTest.testGetAccessTokenWithConfiguredExpiresIn - History

  • expected: <true> but was: <false> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.it.keycloak.OidcClientTest.testGetAccessTokenWithConfiguredExpiresIn(OidcClientTest.java:60)

@gsmet
Copy link
Member

gsmet commented Nov 5, 2024

Oh, apparently, the classes changed under your feet.

@geoand
Copy link
Contributor Author

geoand commented Nov 5, 2024

No problem, I'll update

@geoand
Copy link
Contributor Author

geoand commented Nov 5, 2024

Closing this actually because the change was included in #44129

@geoand geoand closed this Nov 5, 2024
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Nov 5, 2024
@gsmet
Copy link
Member

gsmet commented Nov 5, 2024

@geoand you pointed to an issue?

@geoand
Copy link
Contributor Author

geoand commented Nov 5, 2024

My bad, I meant #44279

@gsmet
Copy link
Member

gsmet commented Nov 5, 2024

Thanks, I wanted to check we have the backport label and it's all good.

@geoand
Copy link
Contributor Author

geoand commented Nov 5, 2024

👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants