Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support left join 44026 #44233

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

aureamunoz
Copy link
Member

@aureamunoz aureamunoz commented Oct 31, 2024

This pull request adds the logic necessary for handling left joins when the search criterion involves a nested field.

Closes: #44026

Copy link

quarkus-bot bot commented Oct 31, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added the area/spring Issues relating to the Spring integration label Oct 31, 2024
@geoand
Copy link
Contributor

geoand commented Nov 1, 2024

See the bot's message above. The title (and description) doesn't really help people just casually looking in understanding what the PR is all about.

@aureamunoz aureamunoz force-pushed the support-left-join-44026 branch 4 times, most recently from b3eda06 to 7a0cb81 Compare November 14, 2024 11:56
@aureamunoz aureamunoz force-pushed the support-left-join-44026 branch 3 times, most recently from 8847019 to 11789fe Compare November 20, 2024 15:45
@aureamunoz aureamunoz marked this pull request as ready for review November 20, 2024 16:48
@aureamunoz
Copy link
Member Author

This is ready for review when you have some time @geoand. Thx in advance :-)

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Nov 21, 2024

💪🏽

I will take a look as soon as I can :)

…ted field. Support 'And' and 'Or' clauses together in method names. Refactors.
@aureamunoz aureamunoz force-pushed the support-left-join-44026 branch from 11789fe to 05ef3ae Compare November 21, 2024 07:59
Copy link

quarkus-bot bot commented Nov 21, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 05ef3ae.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@geoand geoand merged commit 6457815 into quarkusio:main Nov 21, 2024
20 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/spring Issues relating to the Spring integration kind/bugfix
Projects
None yet
2 participants