Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute: if section - adjust the evaluation rules for equality operators #44615

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Nov 21, 2024

@mkouba
Copy link
Contributor Author

mkouba commented Nov 21, 2024

@neon-dev Hopefully this makes a little bit more sense.

Copy link

github-actions bot commented Nov 21, 2024

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 22, 2024
Copy link

quarkus-bot bot commented Nov 22, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 9d8b52b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Nov 22, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 9d8b52b.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 17 Logs Raw logs 🔍
JVM Tests - JDK 21 Build Failures Logs Raw logs 🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 21 #

- Failing: devtools/cli 

📦 devtools/cli

io.quarkus.cli.CliProjectJBangTest.testCreateAppDefaults line 64 - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {
  exitCode: {1},
  system_err: {Downloading JBang...
Error downloading JBang
},
  system_out: {}

io.quarkus.cli.CliProjectJBangTest.testCreateAppOverrides line 98 - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {
  exitCode: {1},
  system_err: {Downloading JBang...
Error downloading JBang
},
  system_out: {}

io.quarkus.cli.CliProjectJBangTest.testCreateCliDefaults line 127 - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {
  exitCode: {1},
  system_err: {Downloading JBang...
Error downloading JBang
},
  system_out: {[DEBUG] Build project with initial parameters: Build [buildOptions=BuildOptions [buildNative=false, clean=true, offline=false, skipTests=false, generateReport=false], properties={property=value1, property2=value2, maven.repo.local=/home/runner/.m2/repository, maven.settings=/home/runner/work/quarkus/quarkus/.github/mvn-settings.xml}, output=OutputOptions [testMode=true, showErrors=true, verbose=true], params=[]]

@mkouba
Copy link
Contributor Author

mkouba commented Nov 22, 2024

It seems that io.quarkus.cli.CliProjectJBangTest failed with Error downloading JBang. Not sure what's going on but it's definitely not related to this PR.

@mkouba mkouba merged commit 8df922d into quarkusio:main Nov 22, 2024
55 of 56 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 22, 2024
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Nov 22, 2024
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.1 Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qute: Unexpected primitive equality
4 participants