Drop mentions of quarkus.ssl.native=false in Hibernate Search guides #44798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think it's a good idea to promote disabling SSL globally and it has been causing issues for users as evidenced in: https://quarkusio.zulipchat.com/#narrow/channel/187030-users/topic/Hibernate.20Search.20-.20Failed.20to.20start.20quarkus Note that the issue was due to a bug in another area but still.
gsmet
commented
Nov 28, 2024
Comment on lines
-639
to
+637
| %prod.quarkus.datasource.jdbc.url=jdbc:postgresql://localhost/quarkus_test <6> | ||
| %prod.quarkus.datasource.jdbc.url=jdbc:postgresql://localhost/quarkus_test |
There was a problem hiding this comment.
This might look odd but the <6> callout was actually reused below and I think this one was bogus.
yrodiere
approved these changes
Nov 28, 2024
yrodiere
added
the
triage/waiting-for-ci
|
🙈 The PR is closed and the preview is expired. |
Status for workflow
|
quarkus-bot
bot
removed
the
triage/waiting-for-ci
gsmet
added
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think it's a good idea to promote disabling SSL globally and it has been causing issues for users as evidenced in: https://quarkusio.zulipchat.com/#narrow/channel/187030-users/topic/Hibernate.20Search.20-.20Failed.20to.20start.20quarkus
Note that the issue was due to a bug in another area but still.