Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SmallRye Config to 3.11.1 #44924

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented Dec 4, 2024

SmallRye Config Release notes:

3.11.0

  • #1287 Move to Java 17
  • #1286 Use static method to create object for leaf properties
  • #1285 Add an equals by region to PropertyName
  • #1284 Builtin Converters for `File` and `URI`
  • #1283 Avoid new HashSet allocation if there are no secrets
  • #1282 Cache the profile converter in ProfileConfigSourceInterceptor
  • #1281 Cache hashCode of PropertyName
  • #1280 Use `Map.forEach` for iterating over values
  • #1279 Avoid using lambda in PropertiesConfigSource
  • #1275 Use `invokeExact` when creating a ConfigMapping object
  • #1274 Replace streams with for loop in customizers handling
  • #1273 Generate properties names with defaults in mapping class
  • #1272 fix: avoid out of range error with long profile names
  • #1271 Bump dependency.version.openwebbeans from 4.0.2 to 4.0.3
  • #1270 check duplicate keys
  • #1268 Source names as constants
  • #1267 Match most specific mapping prefix when matching environment variables
  • #1266 Use config ordinal to determine which config style to use when populating list, between comma-separated and indexed
  • #1265 Bump io.smallrye.common:smallrye-common-bom from 2.8.0 to 2.9.0
  • #1264 Validate mappings on creation instead of on lookup
  • #1263 Improve reportUnknown allocations
  • #1262 Public getter for ConfigValue#problems
  • #1261 Remove deprecated providers
  • #1260 Remove deprecated ConfigMappings#mappedProperties

3.11.1

  • #1289 Proper priority comparator for SmallRyeConfigBuilderCustomizer

Quarkus:

Related:

Breaking Changes:

  • The @ConfigMapping validation with hibernate-validator now executes when the mapping is populated and not when the mapping is first accessed. This means that if there is a validation error in the configuration, Quarkus fails to start.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/hibernate-validator Hibernate Validator labels Dec 4, 2024
@radcortez radcortez added release/breaking-change area/config area/hibernate-validator Hibernate Validator dependencies Pull requests that update a dependency file and removed area/hibernate-validator Hibernate Validator area/dependencies Pull requests that update a dependency file labels Dec 4, 2024
@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Dec 4, 2024
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Jan 10, 2025
@radcortez radcortez marked this pull request as ready for review January 10, 2025 23:28
Copy link

github-actions bot commented Jan 10, 2025

🎊 PR Preview 4b0ff98 has been successfully built and deployed to https://quarkus-pr-main-44924-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

This comment has been minimized.

This comment has been minimized.

Copy link

quarkus-bot bot commented Jan 11, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 65673d7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Jan 11, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 65673d7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

  • Expecting actual: ["-6","-8","-9","-10","-11","-12","-13","-14"] to start with: ["-6", "-7", "-8", "-9"] - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual:
  ["-6","-8","-9","-10","-11","-12","-13","-14"]
to start with:
  ["-6", "-7", "-8", "-9"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:41)

@radcortez radcortez requested a review from gsmet January 13, 2025 11:20
@radcortez radcortez changed the title Update SmallRye Config to 3.11.0 Update SmallRye Config to 3.11.1 Jan 13, 2025
@gsmet
Copy link
Member

gsmet commented Jan 13, 2025

Any reason why these tests are removed?

@radcortez
Copy link
Member Author

The validation is now executed during config creation and not when the mapping is first accessed, meaning that Quarkus will fail to start if the validation fails.

I couldn't find a way to run a @QuarkusTest and assert that the failure is expected (because Quarkus doesn't even start). I've moved the tests to the extension instead, which uses a QuarkusUnitTest: https://github.com/quarkusio/quarkus/pull/44924/files#diff-fdb2327e1025df8cdb276f1eac6cea1f9884f0ee8832c7454e2875c3d41c952dR45-R69

@gsmet gsmet merged commit 95a8ee0 into quarkusio:main Jan 13, 2025
54 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Jan 13, 2025
@quarkus-bot quarkus-bot bot added kind/bugfix kind/enhancement New feature or request labels Jan 13, 2025
@Sanne
Copy link
Member

Sanne commented Jan 13, 2025

Awesome! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/hibernate-validator Hibernate Validator area/vertx dependencies Pull requests that update a dependency file kind/bugfix kind/enhancement New feature or request release/breaking-change triage/flaky-test
Projects
None yet
3 participants