Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure OidcRequestContextProperties are always modifiable #44936

Merged

Conversation

sberyozkin
Copy link
Member

@sberyozkin sberyozkin commented Dec 5, 2024

This is a follow up to #44203, which was not complete because Map.of can be passed to OidcRequestContextProperties from different locations, the test in #44203 works because it just happens that a modifiable map is passed to OidcRequestContextProperties during the token request, with test filters which modify properties being bound to the token request.

Thanks to @sschellh for noticing it.

This comment has been minimized.

@sberyozkin
Copy link
Member Author

Thanks @gastaldi, let me check that flaky test

@sberyozkin sberyozkin force-pushed the mutable_oidc_request_context_props branch from b72f144 to 201460b Compare December 5, 2024 15:10
@sberyozkin
Copy link
Member Author

@gastaldi The test failure is not related but I just added 2 extra secs there to minimize flakiness

Copy link

quarkus-bot bot commented Dec 5, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 201460b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@sberyozkin sberyozkin merged commit a0a8950 into quarkusio:main Dec 5, 2024
23 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 5, 2024
@sberyozkin sberyozkin deleted the mutable_oidc_request_context_props branch December 5, 2024 17:10
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.4 Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants