Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display application name in shutdown message #4501

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Display application name in shutdown message #4501

merged 1 commit into from
Oct 10, 2019

Conversation

gastaldi
Copy link
Contributor

Fixes #4499

@gsmet please review

@gastaldi gastaldi mentioned this pull request Oct 10, 2019
Closed
gsmet
gsmet requested changes Oct 10, 2019
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a very minor comment. Could you address it?

I haven't tested it yet.h

core/runtime/src/main/java/io/quarkus/runtime/Timing.java Outdated Show resolved Hide resolved
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 10, 2019
@gsmet gsmet added this to the 0.25.0 milestone Oct 10, 2019
@gsmet gsmet merged commit c588788 into quarkusio:master Oct 10, 2019
@gastaldi gastaldi deleted the shutdown_message branch October 10, 2019 15:11
@gastaldi gastaldi removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

quarkus.application.name is not taken into account in stop message
2 participants
@gastaldi @gsmet