New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Quarkus Parameter for Disabling Uber-JAR File Name Suffix #45205

Merged

gsmet merged 1 commit into quarkusio:main from jjpinto:patch-2

Jan 6, 2025

Contributor

jjpinto commented Dec 19, 2024 •

edited by geoand

Loading

Updating a Quarkus parameter and the specific context of the Uber-JAR file name suffix.

Fixes: Uber-Jar file name suffix issue for disabling it #45204

quarkus-bot bot added the area/documentation label

jjpinto mentioned this pull request

Uber-Jar file name suffix issue for disabling it #45204

Closed

geoand approved these changes

View reviewed changes

Contributor

geoand left a comment

Thanks!

geoand added the triage/waiting-for-ci label

github-actions bot commented Dec 19, 2024 •

edited

Loading

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

Sign in to view

geoand requested changes

View reviewed changes

Contributor

geoand left a comment

Oops, I misread the change. See #45204 (comment)

geoand removed the triage/waiting-for-ci label

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

Contributor

geoand commented Dec 20, 2024

Can you please rebase the change onto main and squash the commits?

Thanks

gsmet requested changes

View reviewed changes

docs/src/main/asciidoc/maven-tooling.adoc Outdated Show resolved Hide resolved

jjpinto commented

View reviewed changes

Contributor Author

jjpinto left a comment

Updated

Contributor

geoand commented Dec 23, 2024

Cool!

Can you please squash the commits and rebase onto main?

This comment has been minimized.

Sign in to view

jjpinto requested review from geoand and gsmet

December 23, 2024 17:01

This comment has been minimized.

Sign in to view

Contributor Author

jjpinto commented Dec 23, 2024

Cool!

Can you please squash the commits and rebase onto main?
It seems that was rebased but it shows an error in the merge commit. Any help would be great! Thanks

Contributor

geoand commented Dec 23, 2024

No problem, I'll take care of it tomorrow

geoand force-pushed the patch-2 branch from 97f3eb2 to 1cc90be Compare

December 24, 2024 08:19

Contributor

geoand commented Dec 24, 2024

PR updated!

geoand approved these changes

View reviewed changes

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

Contributor Author

jjpinto commented Jan 6, 2025

@gsmet when you get a chance, could you please review.

gsmet approved these changes

View reviewed changes

Member

gsmet left a comment

Awesome, thanks!


          Update Quarkus Parameter for Disabling Uber-JAR File Name Suffix

220281d

gsmet force-pushed the patch-2 branch from 7c6785f to 220281d Compare

January 6, 2025 16:12

Member

gsmet commented Jan 6, 2025

I rebased to drop the merge commit.

quarkus-bot bot commented Jan 6, 2025

Status for workflow `Quarkus Documentation CI`

This is the status report for running Quarkus Documentation CI on commit 220281d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

gsmet merged commit b3d7c52 into quarkusio:main

5 checks passed

quarkus-bot bot added this to the 3.18 - main milestone

Member

gsmet commented Jan 6, 2025

Thanks for the ping :)

quarkus-bot bot added the kind/bugfix label

gsmet added the triage/backport label

gsmet modified the milestones: 3.18 - main, 3.17.6

gsmet removed the triage/backport label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation kind/bugfix