Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Proxy Configuration Guidance #45254

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Typo in Proxy Configuration Guidance #45254

merged 1 commit into from
Dec 23, 2024

Conversation

gilday
Copy link
Contributor

@gilday gilday commented Dec 23, 2024

HTTP documentation includes guidance for configuring a reverse proxy. It states that the proxy should strip "X-Forwarded" and "X-Forwarded-" headers, but I believe it meant "Forwarded" and "X-Forwarded-" headers.

HTTP documentation includes guidance for configuring a reverse proxy. It states that the proxy should strip "X-Forwarded" and "X-Forwarded-*" headers, but I believe it meant "Forwarded" and "X-Forwarded-*" headers.
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are absolutely right, thanks!

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand merged commit 5f730df into quarkusio:main Dec 23, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 23, 2024
Copy link

github-actions bot commented Dec 23, 2024

😭 Deploy PR Preview failed.

@gilday gilday mentioned this pull request Dec 23, 2024
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.6 Jan 7, 2025
@gsmet gsmet modified the milestones: 3.17.6, 3.15.4 Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants