Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note about SDKMAN! to the Contributing guide #45292

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

sberyozkin
Copy link
Member

No description provided.

@sberyozkin sberyozkin requested a review from gsmet December 26, 2024 17:41
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll refine this a bit after my PTO.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some improvements.

Let's merge!

@gsmet gsmet merged commit 8edf94b into quarkusio:main Jan 29, 2025
3 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Jan 29, 2025
@sberyozkin
Copy link
Member Author

Thanks @gsmet, and apologies for the earlier confusion, thinking I was able to build without Java 17, I realised later my builds started falling after I cleaned up the local maven repository 😀

@sberyozkin sberyozkin deleted the sdkman_note branch January 29, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants