Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve-outputGraph #45405

Closed
wants to merge 6 commits into from
Closed

Conversation

punkratz312
Copy link

@punkratz312 punkratz312 commented Jan 7, 2025

melt down 3 for 1 try-block:

image

Copy link

quarkus-bot bot commented Jan 7, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should count at least 2 words to describe the change properly
  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added the area/core label Jan 7, 2025
@maxandersen
Copy link
Member

@punkratz312 thanks - but what is the improvement you are going for? got a before/after example?

p.s. I saw a bunch of other PR's from you without a description/rationale - I encourage you to put that in as that makes it much easier to review and merge as it provides crucial info on what actually being tried to be fixed.

import java.util.Map;
import java.util.ServiceLoader;
import java.util.Set;
import java.util.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please avoid using .*

if you undo this the diff will be much cleaner.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im sorry i have not done the manual stuff yet. If we merge this, this should be done by computer:

#45372

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxandersen if you agree with this pr i will undo this change to make it mergeable. If not we can close it. Thanks

@punkratz312
Copy link
Author

@punkratz312 thanks - but what is the improvement you are going for? got a before/after example?

p.s. I saw a bunch of other PR's from you without a description/rationale - I encourage you to put that in as that makes it much easier to review and merge as it provides crucial info on what actually being tried to be fixed.

Indeed, this is more of a trial to see if it is generally accepted or not. If the initial draft is fine, I’ll refine it properly. Otherwise, I’d have to invest a lot of time in detailed work on a proposal that’s unlikely to get merged. Even though I know a well-written description would increase the chances, I still believe it’s better to check the initial draft first before diving into the details.

@gastaldi
Copy link
Contributor

It changes the public API and isn't a big improvement, so I'm closing this.

Please take a look at the issues in https://github.com/quarkusio/quarkus/issues?q=sort%3Aupdated-desc+is%3Aopen+label%3A%22good+first+issue%22 if you're looking for an easy task to contribute.

@gastaldi gastaldi closed this Jan 31, 2025
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants