Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry: fix the Redis instrumenter in case of a tainted connection #45439

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Jan 8, 2025

The Vert.x Redis client does not always report the database instance number, because sometimes, it simply isn't known. Specifically, that occurs when the connection is tainted; for example, when a custom database is selected using the SELECT command.

In this case, the trace simply will not include the dabatase instance number.

Fixes #45167

…tion

The Vert.x Redis client does not always report the database instance number,
because sometimes, it simply isn't known. Specifically, that occurs when
the connection is tainted; for example, when a custom database is selected
using the `SELECT` command.

In this case, the trace simply will not include the dabatase instance number.
Copy link

quarkus-bot bot commented Jan 8, 2025

/cc @brunobat (opentelemetry), @radcortez (opentelemetry)

@gsmet
Copy link
Member

gsmet commented Jan 8, 2025

I marked it for backport to 3.17 and 3.15.

Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. Thanks @Ladicek

Copy link

quarkus-bot bot commented Jan 8, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 5589020.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 integration-tests/opentelemetry-quickstart

io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest.buildTimeDisabled - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest was not fulfilled within 200 milliseconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest was not fulfilled within 200 milliseconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest.buildTimeDisabled(OpenTelemetryDisabledTest.java:29)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

@gsmet gsmet merged commit 9eb22bd into quarkusio:main Jan 8, 2025
29 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Jan 8, 2025
@Ladicek Ladicek deleted the fix-redis-instrumentation branch January 8, 2025 13:32
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.7 Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long.parseLong Error with Redis Client Instrumentation
4 participants