-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenTelemetry: fix the Redis instrumenter in case of a tainted connection #45439
Conversation
…tion The Vert.x Redis client does not always report the database instance number, because sometimes, it simply isn't known. Specifically, that occurs when the connection is tainted; for example, when a custom database is selected using the `SELECT` command. In this case, the trace simply will not include the dabatase instance number.
/cc @brunobat (opentelemetry), @radcortez (opentelemetry) |
I marked it for backport to 3.17 and 3.15. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me. Thanks @Ladicek
Status for workflow
|
The Vert.x Redis client does not always report the database instance number, because sometimes, it simply isn't known. Specifically, that occurs when the connection is tainted; for example, when a custom database is selected using the
SELECT
command.In this case, the trace simply will not include the dabatase instance number.
Fixes #45167